March 2023 - wine-gitlab

[PATCH v5 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 10 Mar '23

10 Mar '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- v5: winewayland.drv: Report all advertised monitor modes to Wine. winewayland.drv: Report basic monitor information. win32u: Allow drivers to set the null user driver. winewayland.drv: Perform basic per-process Wayland initialization. winewayland.drv: Add initial unixlib stub. winewayland.drv: Add initial driver stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

2 9

[PATCH v3 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu (＠insn) 10 Mar '23

10 Mar '23

-- v3: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

2 1

Re: [PATCH v2 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu (＠insn) 10 Mar '23

10 Mar '23

I've rebased it now to current upstream. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/246#note_26637

1 0

[PATCH v3 0/1] MR2342: Revert "server: Don't invalidate the newly exposed child region on the parent...
by Jinoh Kang (＠iamahuman) 10 Mar '23

10 Mar '23

Revert "server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children." This reverts commit 33617af8145b6fadfe41d48968a728ff57b3064b. Apparently, the aforementioned commit might cause the expose region to be incorrectly computed when a window transitions from invisible state to visible state. The commit also had caused regression in the following apps: - Wine regedit.exe (bug 54268) - Dn-FamiTracker (bug 52903) - Unity Assets Bundle Extractor (same cause behind bug 52903) It appears that the commit catalyzes discovery of hidden bugs in Wine's window repaint logic. It's also possible that the algorithm for computing the expose region is incomplete. For these reasons, revert this commit for now. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54268 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52903 -- v3: Revert "server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children." https://gitlab.winehq.org/wine/wine/-/merge_requests/2342

2 2

Re: [PATCH v2 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 10 Mar '23

10 Mar '23

Any updates? @huw? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/246#note_26629

1 0

Re: [PATCH 0/3] MR260: ntdll: Improve xstate validation in NtGetContextThread()
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 10 Mar '23

10 Mar '23

As I also play Secret Laboratory, would like to see this merged and then go into upstream proton. Any updates, @gofman? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/260#note_26628

1 0

Re: [PATCH v3 0/5] MR131: wined3d: Introduce wined3d_device_check_format_support().
by Olivia/Isabelle Mahadevan (＠doubledge-spec) 10 Mar '23

10 Mar '23

Any updates? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/131#note_26627

1 0

[PATCH v6 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Fan WenJie (＠fanwenjie) 10 Mar '23

10 Mar '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v6: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

2 2

Re: [PATCH v3 0/2] MR2345: Close the bytestream in IMFMediaSource::Shutdown.
by Derek Lesho (＠dlesho) 10 Mar '23

10 Mar '23

Does the MR also need approval from Zeb, or is there something else wrong? FWIW I think the test failure is erroneous, it's in dinput which is completely unrelated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2345#note_26623

1 0

[PATCH v4 0/8] MR1964: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger (＠stefan) 10 Mar '23

10 Mar '23

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v4: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi: Unlock the wined3d mutex after storing the new target. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi: Call wined3d_swapchain_state_set_fullscreen in d3d12_swapchain_init. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

4 11

2025

2024

2023

2022

wine-gitlab March 2023