March 2023 - wine-gitlab

[PATCH v4 0/8] MR1964: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger (＠stefan) 10 Mar '23

10 Mar '23

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v4: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi: Unlock the wined3d mutex after storing the new target. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi: Call wined3d_swapchain_state_set_fullscreen in d3d12_swapchain_init. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

4 11

[PATCH 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) 10 Mar '23

10 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54640 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

2 1

[PATCH v7 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 10 Mar '23

10 Mar '23

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v7: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 3

[PATCH v5 0/3] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Fan WenJie (＠fanwenjie) 10 Mar '23

10 Mar '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v5: Apply 1 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

4 6

[PATCH 0/2] MR2366: opengl32: Fix missing conversion of glUnmapBuffer_params from 32bit to 64bit.
by Rémi Bernon (＠rbernon) 10 Mar '23

10 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2366

2 3

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Daniel Lehman (＠dlehman25) 10 Mar '23

10 Mar '23

@nsivov this ok to go in? or should i split it and do the tests first or something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_26604

1 0

[PATCH 0/9] MR2365: imm32: More control flow reordering in preparation for ImmLoadIME implementation.
by Rémi Bernon (＠rbernon) 10 Mar '23

10 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2365

2 9

Re: [PATCH v2 0/3] MR2361: ntdll: Fix inverted TlsIndex check
by Francois Gouget (＠fgouget) 10 Mar '23

10 Mar '23

On Thu Mar 9 18:05:24 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=130422 > Your paranoid android. > === w7u_2qxl (32 bit report) === > kernel32: > loader.c:2324: Test failed: wrong tls data 'hello world' at 00C54600 > === w7u_adm (32 bit report) === > kernel32: > loader.c:2324: Test failed: wrong tls data 'hello world' at 00BE4600 > === w7u_el (32 bit report) === > kernel32: > loader.c:2324: Test failed: wrong tls data 'hello world' at 00C546A0 > === w7pro64 (64 bit report) === > kernel32: > loader.c:2324: Test failed: wrong tls data 'hello world' at 0000000000D405F0 > ``` This is a regression in the tests when running on Windows 7. That should have been grounds for rejection of the merge request! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2361#note_26599

1 0

[PATCH 0/3] MR117: tests: Simplify and deduplicate option handling a bit.
by Zebediah Figura (＠zfigura) 09 Mar '23

09 Mar '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/117

4 5

[PATCH v4 0/1] MR2126: ntdll: Print an error if we receive a signal not on the signal stack.
by Zebediah Figura (＠zfigura) 09 Mar '23

09 Mar '23

Without this patch the process will silently die. I managed to trigger this while trying to trace Child of Light with Renderdoc, the latter of which crashed in its own "TargetControlServerThread". This, confusingly, manifested in the game restarting itself without the Ubisoft overlay; apparently the game or one of its launchers was capable of recognizing when the process had died and restarting it, but would not try to inject the overlay a second time. I have not investigated the cause of the crash; it is not unlikely that it resulted from the overlay injection (despite the fact that that should only directly affect PE code.) -- v4: ntdll: Print an error if we receive a signal not on the signal stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/2126

4 8

2025

2024

2023

2022

wine-gitlab March 2023