March 2023 - wine-gitlab

[PATCH 0/1] MR118: vkd3d-shader: Fix a few typos in the comments.
by Nikolay Sivov (＠nsivov) 09 Mar '23

09 Mar '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/118

5 4

[PATCH v4 0/10] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) 09 Mar '23

09 Mar '23

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v4: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). vkd3d-shader/hlsl: Rename struct hlsl_reg_reservation fields. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

4 15

[PATCH 0/1] MR2358: gdi32: Improve EMR_CREATEDIBPATTERNBRUSHPT playback.
by Piotr Caban (＠piotr) 09 Mar '23

09 Mar '23

It makes the lbHatch data available after PlayEnhMetaFileRecord returns. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2358

3 2

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

To keep things consistent with the other WOW64 thunks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26528

1 0

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c: > > status = wow64_unmap_buffer( ptr, get_named_buffer_param( teb, params32->buffer, GL_BUFFER_MAP_LENGTH ), > get_named_buffer_param( teb, params32->buffer, GL_BUFFER_ACCESS_FLAGS ) ); > gl_unmap_named_buffer64( args ); ```suggestion:-7+0 struct glUnmapNamedBuffer_params params = { .teb = get_teb64(params32->teb), .buffer = params32->buffer, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_named_buffer_pointer( params.teb, params.buffer ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_MAP_LENGTH ), get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_named_buffer64( &params ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26527

1 0

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c: > } *params32 = args; > NTSTATUS status; > TEB *teb = get_teb64( params32->teb ); > + struct glUnmapBuffer_params params = { teb, params32->target, params32->ret }; > > if (!(ptr = get_buffer_pointer( teb, params32->target ))) return STATUS_SUCCESS; > > status = wow64_unmap_buffer( ptr, get_buffer_param( teb, params32->target, GL_BUFFER_MAP_LENGTH ), > get_buffer_param( teb, params32->target, GL_BUFFER_ACCESS_FLAGS ) ); > - gl_unmap_buffer64( args ); > + gl_unmap_buffer64( &params ); ```suggestion:-8+0 struct glUnmapBuffer_params params = { .teb = get_teb64(params32->teb), .target = params32->target, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_buffer_pointer( params.teb, params.target ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_buffer_param( params.teb, params.target, GL_BUFFER_MAP_LENGTH ), get_buffer_param( params.teb, params.target, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_buffer64( &params ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26526

1 0

[PATCH 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Fan WenJie (＠fanwenjie) 09 Mar '23

09 Mar '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

2 1

Re: [PATCH v3 0/1] MR2346: winsqlite3: Add stub DLL.
by Jinoh Kang (＠iamahuman) 09 Mar '23

09 Mar '23

We should probably bundle `winsqlite3.dll` in the same manner we do for `wine-mono`, `wine-gecko`, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2346#note_26523

1 0

[PATCH 0/1] MR2357: windows.perception.stub/tests: Skip some tests when ISpatialSurfaceObserverStatics2 is not supported.
by Francois Gouget (＠fgouget) 09 Mar '23

09 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54649 --- This fixes the crash on Windows 10 1607. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2357

2 1

[PATCH v3 0/5] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

-- v3: win32u: Call NtUserActivateKeyboardLayout on focus change. winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

2 6

2025

2024

2023

2022

wine-gitlab March 2023