April 2023 - wine-gitlab

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Alexandre Julliard (＠julliard) 26 Apr '23

26 Apr '23

I'm not convinced that this justifies a Wine-specific module. The usual solution for problems with native dlls is "don't do that", i.e. fix the builtin so that native is not required. It's hard to tell without more details, but in this case an app-specific dll override may also be enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31218

1 0

[PATCH v3 0/1] MR2602: mfplat: Fix returned buffer length in dxgi_surface_buffer_lock().
by Paul Gofman (＠gofman) 26 Apr '23

26 Apr '23

-- v3: mfplat: Fix returned buffer length in dxgi_surface_buffer_lock(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2602

3 3

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Nikolay Sivov (＠nsivov) 26 Apr '23

26 Apr '23

How bad would it be to duplicate tests in msxml3/4/6, removing version checks completely? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_31211

1 0

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Nikolay Sivov (＠nsivov) 26 Apr '23

26 Apr '23

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c: > } > > test = tests; > - while (test->xml) { > + while (test->xml) > + { > + if (test->versions && !(entry->ver & test->versions)) > + { > + test++; > + continue; > + } I don't see "versions" field set anywhere? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_31210

1 0

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Nikolay Sivov (＠nsivov) 26 Apr '23

26 Apr '23

This looks fine to me, if wine-specific modules are a problem, we'll need to build separate modules, increasing build size like @tclem said. But that's not my call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31209

1 0

[PATCH 0/2] MR2708: Two misc janitorings
by Michael Stefaniuc (＠mstefani) 26 Apr '23

26 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2708

3 3

[PATCH v4 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) 26 Apr '23

26 Apr '23

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v4: mfreadwrite/tests: Test GetService for MP4 sink writer. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 3

[PATCH 0/3] MR2705: d3dcompiler: D3DAssemble is a private export.
by Stefan Dösinger (＠stefan) 26 Apr '23

26 Apr '23

This series allows linking of our d3dx9.dll against d3dcompiler.lib from the Windows SDK. It presumably also fixes the d3dcompiler tests, although I didn't bother building them with Visual Studio so far. And yes, I did check, that stringification macro works on MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2705

4 11

[PATCH 0/5] MR2676: dxgi, d3d9: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) 26 Apr '23

26 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2676

3 7

Re: [PATCH v2 0/1] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Giovanni Mascellani (＠giomasce) 26 Apr '23

26 Apr '23

I think it would be preferable to have to test in the repository, even if it hardcodes the render target size. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179#note_31201

1 0

2025

2024

2023

2022

wine-gitlab April 2023