April 2023 - wine-gitlab

[PATCH 0/1] MR2593: Draft: winex11.drv: Use the proper id with the settings handler.
by Alexandros Frantzis (＠afrantzis) 05 Apr '23

05 Apr '23

The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Fixes: 4232312dffe1cd115aa6bfd755f5b7c6a403e3fc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54781 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

2 3

Re: [PATCH v23 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Alexandre Julliard (＠julliard) 05 Apr '23

05 Apr '23

Alexandre Julliard (@julliard) commented about dlls/ntdll/unix/file.c: > -static BOOL is_hidden_file( const UNICODE_STRING *name ) > +static BOOL is_hidden_file( const char *name ) > { > - WCHAR *p, *end; > + const char *p, *end; > > if (show_dot_files) return FALSE; > > - end = p = name->Buffer + name->Length/sizeof(WCHAR); > - while (p > name->Buffer && p[-1] == '\\') p--; > - while (p > name->Buffer && p[-1] != '\\') p--; > - return (p < end && *p == '.'); > + end = p = name + strlen( name ); > + while (p > name && p[-1] == '/') p--; > + while (p > name && p[-1] != '/') p--; > + return (p < end && p + 1 != end && p[0] == '.' && p[1] != '\\' && (p[1] != '.' || (p + 2 != end && p[2] != '\\'))); This doesn't make sense, it's using the wrong slashes and shouldn't be necessary in the first place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29029

1 0

Re: [PATCH v23 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Alexandre Julliard (＠julliard) 05 Apr '23

05 Apr '23

Alexandre Julliard (@julliard) commented about dlls/ntdll/tests/threadpool.c: > info2.ticks = 0; > > NtQuerySystemTime( &when ); > - when.QuadPart += (ULONGLONG)250 * 10000; > + when.QuadPart += (ULONGLONG)500 * 10000; > pTpSetTimer(timer2, &when, 0, 0); > - Sleep(50); > - when.QuadPart -= (ULONGLONG)150 * 10000; > - pTpSetTimer(timer1, &when, 0, 75); > + Sleep(100); > + when.QuadPart -= (ULONGLONG)300 * 10000; > + pTpSetTimer(timer1, &when, 0, 150); > > result = WaitForSingleObject(semaphore, 1000); Please don't add unrelated changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29028

1 0

[PATCH 0/12] MR2589: msvcrt: Use a few more functions from the bundled musl library.
by Alexandre Julliard (＠julliard) 05 Apr '23

05 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2589

3 13

[PATCH v4 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) 05 Apr '23

05 Apr '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- v4: winemenubuilder: Skip desktop integration for certain associations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

3 3

[PATCH v2 0/1] MR2417: setupapi: Stub in CM_MapCrToWin32Err
by James McDonnell (＠ElementalWarrior) 05 Apr '23

05 Apr '23

Stub for affinity photo -- v2: setupapi: Stub in CM_MapCrToWin32Err https://gitlab.winehq.org/wine/wine/-/merge_requests/2417

4 4

[PATCH v4 0/1] MR137: vkd3d: Leave the command queue op mutex locked after a partial flush.
by Conor McCarthy (＠cmccarthy) 05 Apr '23

05 Apr '23

All return paths in d3d12_command_queue_flush_ops_locked() must leave the op mutex locked. -- v4: vkd3d: Leave the command queue op mutex locked after a partial flush. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/137

3 4

[PATCH 0/1] MR2591: include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer...
by Stefan Dösinger (＠stefan) 05 Apr '23

05 Apr '23

include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer are intrinsics in x86 msvc. I fixed this issue in ad05f33d67, but a40973f20 regressed this again. I was carrying a patch for quite a while, feeling dejavu. The msvc ver of 1900 is taken from Boost's interlocked.hpp, which matches MSVC 2015 (toolset version v140). Boost has a comment that claims that in msvc 2012 those functions were defined in intrin.h, but those defines are broken with Microsoft's winnt.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2591

3 2

[PATCH 0/1] MR2590: setupapi: Use CRT functions for memory allocation where possible.
by Alex Henrie (＠alexhenrie) 05 Apr '23

05 Apr '23

The big win here is getting rid of the reimplementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2590

2 1

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon (＠rbernon) 05 Apr '23

05 Apr '23

On Wed Apr 5 09:07:47 2023 +0000, Byeongsik Jeon wrote: > I tested a bit of code, it appears that fdwInit is also cached during > IME switching. Yeah I'm thinking that the entire `INPUTCONTEXT` is probably switched and kept cached, to avoid sharing its contents with a different IME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_29002

1 0

2025

2024

2023

2022

wine-gitlab April 2023