Hi Yeshun, you don't need to regularly rebase the MR on top of the latest master. Because this area of code is largely undocumented, to help this MR gets in, you need to add a test, even if it might not be easy. I think you can use some of the example codes in NCALRPC_example. Thanks.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29113
On Tue Apr 4 19:02:38 2023 +0000, Zebediah Figura wrote:
> It's hard for me to feel like this is an improvement, when we are now
> adding an extra parameter to every call, and also using some
> undocumented Windows functions that, to the reader, might have some
> obscure different semantics.
Based on that feedback, I am closing this merge request in favor of !2590, which at least gets rid of the duplicate implementation of wcsdup.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_29106