April 2023 - wine-gitlab

[PATCH v2 0/3] MR2573: dinput: Set guidType = GUID_Unknown for HID collections.
by Florian Will (＠w-flo) 04 Apr '23

04 Apr '23

I'm not sure if I'm using the dinput HID test infrastructure correctly. Also, an existing test could be extended instead of adding a whole new test function, saving a couple of source code lines and test execution time, but I wasn't sure which one to extend - feel free to suggest one and I will update the test. Also, maybe the suggested fix is not a great idea. Maybe there are actually some collection objects that are supposed to have a guidType that is not GUID_Unknown? I couldn't find any in the limited number of Windows environments I can access, so I wanted to put it out there for discussion. The issue I'm trying to solve is that Zusi 3 does not appear to check the DIDFT_NODATA bit in dwType, so it just adds most of the objects listed by EnumObjects() to the SetDataFormat() call, maybe filtering out only those that have guidType = GUID_Unknown, or maybe there's an allow-list of GUIDs to add, and that list includes GUID_ZAxis. I haven't seen complaints about joysticks not working in Zusi 3 on Windows, so I guess collections (and DIDFT_NODATA objects in general) rarely/never have a non-Unknown GUID, or maybe Windows simply accepts these collections in SetDataFormat() and that only fails in Wine. -- v2: dinput/tests: Remove unmatched winetest_pop_context(). dinput: Set guidType = GUID_Unknown for HID collections. dinput/tests: Add guidType test for collection objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

3 6

[PATCH 0/1] MR2572: wldap32: Skip over the TLS certificate check if not using TLS.
by Alex Henrie (＠alexhenrie) 04 Apr '23

04 Apr '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54772 I could have fixed this in merge request !2533 but unfortunately I was so focused on testing SSL connections that I didn't notice that non-SSL connections were still broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2572

4 3

[PATCH 0/2] MR2573: dinput: Set guidType = GUID_Unknown for HID collections.
by Florian Will (＠w-flo) 04 Apr '23

04 Apr '23

I'm not sure if I'm using the dinput HID test infrastructure correctly. Also, an existing test could be extended instead of adding a whole new test function, saving a couple of source code lines and test execution time, but I wasn't sure which one to extend - feel free to suggest one and I will update the test. Also, maybe the suggested fix is not a great idea. Maybe there are actually some collection objects that are supposed to have a guidType that is not GUID_Unknown? I couldn't find any in the limited number of Windows environments I can access, so I wanted to put it out there for discussion. The issue I'm trying to solve is that Zusi 3 does not appear to check the DIDFT_NODATA bit in dwType, so it just adds most of the objects listed by EnumObjects() to the SetDataFormat() call, maybe filtering out only those that have guidType = GUID_Unknown, or maybe there's an allow-list of GUIDs to add, and that list includes GUID_ZAxis. I haven't seen complaints about joysticks not working in Zusi 3 on Windows, so I guess collections (and DIDFT_NODATA objects in general) rarely/never have a non-Unknown GUID, or maybe Windows simply accepts these collections in SetDataFormat() and that only fails in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

3 5

[PATCH 0/7] MR2574: imm32: Fix and cleanup ImmTranslateMessage.
by Rémi Bernon (＠rbernon) 04 Apr '23

04 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2574

2 7

[PATCH 0/1] MR2570: winegstreamer: Fix check for non-zero padding in h264 transform.
by Paul Gofman (＠gofman) 04 Apr '23

04 Apr '23

IsRectEmpty() doesn't do the right thing as padding is not a rectangle. E. g., for rect (0, 0, 0, 8) IsRectEmpty() will return TRUE while the padding is apparently not empty. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2570

3 2

[PATCH v5 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Yeshun Ye (＠yeyeshun) 04 Apr '23

04 Apr '23

There is an application uses DirectSound to play waves and uses IAudioEndpointVolume to adjust the volume, but there is no effect on the volume adjustment. -- v5: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar' https://gitlab.winehq.org/wine/wine/-/merge_requests/2565

2 1

Re: [PATCH v2 0/7] MR2562: winex11: Preparatory XIM cleanup. - approved
by Alexandre Julliard (＠julliard) 03 Apr '23

03 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2562

1 0

Re: [PATCH v6 0/1] MR1753: wintrust: Annotate WINTRUST_Alloc with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 03 Apr '23

03 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1753

1 0

Re: [PATCH v5 0/5] MR2532: kernebase: Implement GetConsoleOriginalTitleA/W - approved
by Alexandre Julliard (＠julliard) 03 Apr '23

03 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2532

1 0

Re: [PATCH v3 0/1] MR2550: wintypes: Declare exported functions in rometadataresolution.h. - approved
by Alexandre Julliard (＠julliard) 03 Apr '23

03 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2550

1 0

2025

2024

2023

2022

wine-gitlab April 2023