May 2023 - wine-gitlab

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 27 May '23

27 May '23

> I'd also like to see the result of getsockname() on all tested paths. On Windows, `getsockname` returns -1 with `WSAEINVAL` when called on an AF_UNIX socket. However, the paths you delineate are all valid to `bind` to. > What protocol do these sockets actually have? I.e. what does SO_PROTOCOL_INFO return for them? 0 is usually a wildcard. Windows returns the following: ``` dwServiceFlags1: 0x00020026 // (XP1_GUARANTEED_DELIVERY | XP1_GUARANTEED_ORDER | XP1_IFS_HANDLES) dwServiceFlags2: <reserved> dwServiceFlags3: <reserved> dwServiceFlags4: <reserved> dwProviderFlags: 8 ProviderId: <GUID> dwCatalogEntryId: 1007 ProtocolChain: { ChainLen: 1, ChainEntries: { 0 } } iVersion: 2 iAddressFamily: 1 iMaxSockAddr: 110 iMinSockAddr: 2 iSocketType: 1 iProtocol: 0 iProtocolMaxOffset: 0 iNetworkByteOrder: 0 iSecurityScheme: 0 dwMessageSize: 0 dwProviderReserved: <reserved> szProtocol: AF_UNIX ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_34026

1 0

Re: [PATCH v3 0/1] MR2865: gdiplus: Handle Windows style newline.
by David Kahurani (＠kahurani) 27 May '23

27 May '23

On Fri May 26 18:59:04 2023 +0000, Esme Povirk wrote: > You'll want to check the length passed in, something like `lret + 1 < > fit` maybe. We can't assume the string is null-terminated. Woops, sorry. I didn't think of that -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2865#note_34025

1 0

[PATCH 0/4] MR2919: winsock: Make more waits alertable.
by Paul Gofman (＠gofman) 27 May '23

27 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2919

3 5

[PATCH 0/2] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl.
by Zebediah Figura (＠zfigura) 27 May '23

27 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

3 3

[PATCH v2 0/8] MR2907: wine{alsa,coreaudio,oss,pulse}: Move AudioClient2 into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 26 May '23

26 May '23

To be merged after !2906. -- v2: wineoss: Use mmdevapi's AudioClient2. winecoreaudio: Use mmdevapi's AudioClient2. winealsa: Use mmdevapi's AudioClient2. winepulse: Move AudioClient2 into mmdevapi. wineoss: Use mmdevapi's AudioClient3. winecoreaudio: Use mmdevapi's AudioClient3. winealsa: Use mmdevapi's AudioClient3. winepulse: Move AudioClient3 into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2907

2 8

[PATCH v2 0/4] MR2906: wine{alsa,coreaudio,oss,pulse}: Move AudioClient3 into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 26 May '23

26 May '23

-- v2: wineoss: Use mmdevapi's AudioClient3. winecoreaudio: Use mmdevapi's AudioClient3. winealsa: Use mmdevapi's AudioClient3. winepulse: Move AudioClient3 into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2906

2 5

[PATCH v2 0/2] MR2899: winegstreamer: Only warn on wg_transform input buffer push errors.
by Rémi Bernon (＠rbernon) 26 May '23

26 May '23

Some GStreamer plugins such as openh264 return spurious errors when running the tests. They pass the tests successfull if we simply ignore them. It does not make much difference with returning the error, as they are not supposed to happen anyway, and most of the time the MFT clients don't expect or handle errors. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2893 as this is also orthogonal and only fixes the tests when running them with openh264, which is not the case on either the testbot or Gitlab. -- v2: winegstreamer: Set the default H264 caps profile to "baseline". winegstreamer: Only warn on wg_transform input buffer push errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/2899

3 7

[PATCH v2 0/1] MR2898: winegstreamer: Forbid vaapidecodebin when looking for a specific element.
by Rémi Bernon (＠rbernon) 26 May '23

26 May '23

This will eventually fallback to vaapih264dec and similar decoders if VA-API plugins are indeed available. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2893, as this doesn't have any effect unless VA-API plugins are installed, and they aren't on the testbot or Gitlab. -- v2: winegstreamer: Forbid vaapidecodebin when looking for a specific element. https://gitlab.winehq.org/wine/wine/-/merge_requests/2898

3 2

[PATCH v4 0/1] MR2892: wined3d: Fix uninitialized variable warning.
by Davide Beatrici (＠davidebeatrici) 26 May '23

26 May '23

```c dlls/wined3d/context_vk.c:2377:42: warning: ‘null_binding’ may be used uninitialized in this function [-Wmaybe-uninitialized] 2377 | *null_buffer_binding = b->binding = null_binding; | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` -- v4: wined3d: Fix uninitialized variable warning. https://gitlab.winehq.org/wine/wine/-/merge_requests/2892

3 2

Re: [PATCH v2 0/1] MR2917: d2d1: Improve resource properties check when creating a bitmap. - approved
by Alexandre Julliard (＠julliard) 26 May '23

26 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2917

1 0

2025

2024

2023

2022

wine-gitlab May 2023