June 2023 - wine-gitlab

[PATCH 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 07 Jun '23

07 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: - Fix typo in commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

2 1

Re: [PATCH v2 0/2] MR3006: gdiplus: Improve performance of drawing, by reducing not needed calculations
by Alex Henrie (＠alexhenrie) 07 Jun '23

07 Jun '23

Alex Henrie (@alexhenrie) commented about dlls/gdiplus/graphics.c: > } > } > > +/* Creates rotated and translated identity matrix. > + * Equvalent (but much faster) of the: > + * GdipSetMatrixElements(&matrix, 1.0, 0.0, 0.0, 1.0, 0.0, 0.0); > + * GdipRotateMatrix(&matrix, angle, MatrixOrderAppend); > + * GdipTranslateMatrix(&matrix, dx, dy, MatrixOrderAppend); */ > +inline void create_rotated_translated_identity_matrix(GpMatrix *matrix, REAL angle, REAL dx, REAL dy) This function should be `static` and not `inline`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3006#note_34990

1 0

[PATCH 0/1] MR3003: mf/tests: Remove duplicate call to MFStartup().
by Bernhard Kölbl (＠besentv) 07 Jun '23

07 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3003

3 4

[PATCH 0/1] MR3005: localspl: Don't pass original document name to cupsStartDocument.
by Piotr Caban (＠piotr) 07 Jun '23

07 Jun '23

It's used by the function to find document content type. Fixes regression introduced by e164b8cefb9dfbf0af5b83e176a386eb2c490d6b. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3005

3 2

[PATCH v4 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 07 Jun '23

07 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v4: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

4 5

[PATCH v5 0/5] MR207: vkd3d-shader/hlsl: Support non-constant offset dereferences, part 1
by Francisco Casas (＠fcasas) 07 Jun '23

07 Jun '23

Indexing with non-constants offsets requires relative addressing in SM4. In assembly, this is written like in the following example: ``` x1[r1.x + 3] ``` The first part of this patch series only includes support for indexing vectors with non-constant indexes. Following patches in https://gitlab.winehq.org/fcasas/vkd3d/-/commits/nonconst-offsets-3. --- Non-constant indexing of vectors cannot be implemented with relative addressing in SM4 because this indexation cannot be performed at the level of register-components, only whole registers. Mathematical operations must be used instead. For floats, the native compiler seems to index an identity matrix, to get the i-th column, and then proceedes to compute the dot product between that column and the vector. For ints, bit operations seem to be performed. While probably less efficient, this implementation complies with the type-checking at the IR level and when writing bytecode. -- v5: vkd3d-shader/hlsl: Support non-constant vector indexing. vkd3d-shader/hlsl: Lower dot for non-float types. vkd3d-shader/hlsl: Introduce transform_derefs(). tests: Test indexing temps. tests: Test non-constant vector indexing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/207

4 8

[PATCH v2 0/2] MR225: vkd3d-shader/tpf: Read complete swizzle/mask info from parameter tokens.
by Conor McCarthy (＠cmccarthy) 07 Jun '23

07 Jun '23

-- v2: vkd3d-shader/tpf: Read complete swizzle/mask info for dst params. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/225

3 3

[PATCH v2 0/7] MR223: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 7.
by Zebediah Figura (＠zfigura) 07 Jun '23

07 Jun '23

BORING -- v2: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_constant(). vkd3d-shader/hlsl: Pass a hlsl_constant_value pointer to hlsl_new_constant(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_or(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_and(). vkd3d-shader/hlsl: Pass hlsl_constant_value and hlsl_type pointers to fold_bit_xor(). vkd3d-shader/hlsl: Only read used coordinates in encode_texel_offset_as_aoffimmi(). vkd3d-shader/hlsl: Use the writemask to map the coords swizzle for load instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/223

4 12

[PATCH v5 0/1] MR211: vkd3d-shader/hlsl: Support clip() intrinsic.
by Nikolay Sivov (＠nsivov) 07 Jun '23

07 Jun '23

-- v5: vkd3d-shader/hlsl: Support clip() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/211

5 12

[PATCH 0/5] MR3004: mf/session: Pull more samples from upstream if MFT has pending requests.
by Rémi Bernon (＠rbernon) 07 Jun '23

07 Jun '23

This will be required for MFT decoder transforms to work. They don't usually produce an output sample on every pushed input sample, and the session may need to request more sample from upstream and push them into the transform or it will not get any output and get stuck. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3004

2 5

2025

2024

2023

2022

wine-gitlab June 2023