June 2023 - wine-gitlab

Re: [PATCH v3 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Huw Davies (＠huw) 08 Jun '23

08 Jun '23

Huw Davies (@huw) commented about dlls/sapi/uuid.c: > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "initguid.h" > + > +DEFINE_GUID(SPDFID_Text, 0x7ceef9f9, 0x3d13, 0x11d2, 0x9e, 0xe7, 0x00, 0xc0, 0x4f, 0x79, 0x73, 0x96); > +DEFINE_GUID(SPDFID_WaveFormatEx, 0xc31adbae, 0x527f, 0x4ff5, 0xa2, 0x30, 0xf6, 0x2b, 0xb6, 0x1f, 0xf7, 0x0c); Adding a new source file just for the guids seems a bit of an overkill. Can't we just add these to another file? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2992#note_35072

1 0

[PATCH 0/1] MR3017: regedit: Fix memory leak on error path in GetItemPath (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3017

2 1

[PATCH 0/1] MR3014: winegstreamer: Fix double free on error path in media_source_constructor (scan-build).
by Alex Henrie (＠alexhenrie) 08 Jun '23

08 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3014

2 1

[PATCH v2 0/4] MR2992: sapi: Implement basic functionality for SpMMAudioOut.
by Shaun Ren (＠shaunren) 08 Jun '23

08 Jun '23

-- v2: sapi: Implement ISpMMSysAudio::Get/SetFormat. include: Add sperror error code SPERR_UNSUPPORTED_FORMAT. sapi: Add GUIDs SPDFID_Text/WaveFormatEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/2992

2 4

[PATCH 0/3] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 07 Jun '23

07 Jun '23

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 12

[PATCH v2 0/1] MR3007: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 07 Jun '23

07 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: - Fix typo in commit message. -- v2: ntdll: Avoid requests with null pointer but invalid size. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 4

Re: [PATCH v5 0/10] MR2994: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's SetEventHandle, Reset, Stop, Start into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jun '23

07 Jun '23

On Wed Jun 7 06:54:43 2023 +0000, Davide Beatrici wrote: > I've actually thought about both points. > I will add `CreateThread()`'s failure handling in a subsequent merge request. !3008 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2994#note_35032

1 0

Re: [PATCH v2 0/1] MR3003: mf/tests: Remove duplicate call to MFStartup(). - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3003

1 0

Re: [PATCH v2 0/1] MR3005: localspl: Don't pass original document name to cupsStartDocument. - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3005

1 0

Re: [PATCH v7 0/4] MR2918: xaudio2: Use the preprocessor to modify definitions in xaudio2.idl and xaudio2fx.idl. - approved
by Alexandre Julliard (＠julliard) 07 Jun '23

07 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2918

1 0

2025

2024

2023

2022

wine-gitlab June 2023