July 2023 - wine-gitlab

[PATCH v2 0/6] MR3220: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector().
by Mohamad Al-Jaf (＠maljaf) 03 Jul '23

03 Jul '23

Needed for Revo Scan 5. -- v2: windows.devices.bluetooth: Partially implement IBluetoothAdapterStatics::GetDeviceSelector(). windows.devices.bluetooth/tests: Add IBluetoothAdapterStatics::GetDeviceSelector() tests. windows.devices.bluetooth: Add IBluetoothAdapterStatics stub interface. windows.devices.bluetooth: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3220

2 7

[PATCH 0/1] MR3225: pnputil: Add stub program.
by Mohamad Al-Jaf (＠maljaf) 03 Jul '23

03 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55178 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3225

2 1

[PATCH 0/1] MR3224: shell32: Don't overallocate in Dde_OnRequest (scan-build).
by Alex Henrie (＠alexhenrie) 02 Jul '23

02 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3224

2 1

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alexandre Julliard (＠julliard) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:51:00 2023 +0000, Alex Henrie wrote: > atlbase.h, atlcom.h, and atlwin.h are also C++-only in Windows, but Wine > allows them to be used in C and uses them in its own C code. I assumed > that the same logic would apply to atlconv.h, but if that doesn't work > then we may want to introduce a new helper in include/wine. We have the other headers but we use them only for the ATL implementation. They are not something we'd want to use globally. As for a new include/wine helper, there doesn't seem to be enough usage of that function to justify it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37561

1 0

[PATCH 0/1] MR3222: localspl: Add workaround for old versions of cups.h
by Fabian Maurer (＠DarkShadow44) 02 Jul '23

02 Jul '23

Recent versions of cups.h have HTTP_STATUS_CONTINUE as enum, so defining it doesn't hurt -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3222

3 2

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alex Henrie (＠alexhenrie) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:29:53 2023 +0000, Alexandre Julliard wrote: > A2BSTR is a C++ only macro, it's not something we'd want to use as a > standard replacement. atlbase.h, atlcom.h, and atlwin.h are also C++-only in Windows, but Wine allows them to be used in C and uses them in its own C code. I assumed that the same logic would apply to atlconv.h, but if that doesn't work then we may want to introduce a new helper in include/wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37559

1 0

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alexandre Julliard (＠julliard) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:29:26 2023 +0000, Michael Stefaniuc wrote: > Sorry, forgot about that A2BSTR is a C++ only macro, it's not something we'd want to use as a standard replacement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37558

1 0

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Michael Stefaniuc (＠mstefani) 02 Jul '23

02 Jul '23

On Sun Jul 2 20:14:43 2023 +0000, Alex Henrie wrote: > @mstefani Thanks for the feedback. Would you be willing to remove your > downvote now that the scope of this MR has been reduced? Sorry, forgot about that -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37557

1 0

[PATCH 0/1] MR3221: dcomp: Add stub for DCompositionCreateDevice3
by Fabian Maurer (＠DarkShadow44) 02 Jul '23

02 Jul '23

This is needed by recent chromium -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3221

2 1

Re: [PATCH v3 0/3] MR3191: include: Add A2BSTR function.
by Alex Henrie (＠alexhenrie) 02 Jul '23

02 Jul '23

On Sun Jul 2 17:27:26 2023 +0000, Michael Stefaniuc wrote: > My comment was referring to the tests where we convert ascii string literals. > The two left commits seem fine though as those don't just convert ascii > string literals in the code. > But I had just a quick look at them. @mstefani Thanks for the feedback. Would you be willing to remove your downvote now that the scope of this MR has been reduced? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3191#note_37554

1 0

2025

2024

2023

2022

wine-gitlab July 2023