July 2023 - wine-gitlab

[PATCH v2 0/7] MR3271: windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly().
by Mohamad Al-Jaf (＠maljaf) 10 Jul '23

10 Jul '23

Needed for Lenovo Ready for Assistant. -- v2: windows.devices.usb/tests: Add IUsbDeviceStatics::GetDeviceSelectorVidPidOnly() tests. windows.devices.usb: Implement IUsbDeviceStatics::GetDeviceSelectorVidPidOnly(). windows.devices.usb: Add IUsbDeviceStatics stub interface. windows.devices.usb: Add stub DLL. include: Add windows.devices.usb.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3271

2 10

[PATCH v10 0/1] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhao Yi (＠Zhaoyi) 10 Jul '23

10 Jul '23

Fix the issue of incorrect linkid calculation due to a lack of judgment on the current type. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v10: comctl32/tests: Add a test case to get syslinkid. https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

2 1

Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 10 Jul '23

10 Jul '23

On Sat Jul 8 07:23:37 2023 +0000, Rémi Bernon wrote: > You should only call `WindowsDeleteString` if the refcount gets to 0 > (and then you should also free the hostname, which I also missed). Yeah, sorry for missing that. I've just been very burned out with life in general. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_38470

1 0

[PATCH v4 0/2] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v4: Update ka.po https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

3 4

[PATCH v3 0/1] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v3: po: Add Georgian translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

4 3

[PATCH v2 0/1] MR3275: po: Add Georgian translation.
by Ekaterine Papava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation. -- v2: po: Add Georgian translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

3 3

[PATCH 0/2] MR3275: po: Add Georgian translation
by EkaterinePapava (＠EkaterinePapava) 10 Jul '23

10 Jul '23

po: Add Georgian translation -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3275

4 4

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

On Mon Jul 10 01:45:21 2023 +0000, Zhao Yi wrote: > Thank you for reviewing my code and I will fix the above issue later. There is no need to rush this. Please take your time to carefully review the code by yourself before submitting it for review. Look out for coding style issues and review each line you've changed. Overall, the fix looks good. Thanks for your work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38455

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > HWND hWndSysLink; > > /* Only Unicode will do here */ > - hWndSysLink = CreateWindowExW(0, WC_LINK, L"Head <a href=\"link1\">Name1</a> Middle <a href=\"link2\">Name2</a> Tail", > + hWndSysLink = CreateWindowExW(0, WC_LINK, L"Head <a href=\"link1\">Name1</a> Middle <a href=\"link2\">Name2</a> Middle <a href=\"link3\">Name3</a> Tail", Do you really need to create a link3? Can't you use link2? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38454

1 0

Re: [PATCH v9 0/2] MR3114: comctl32: Make sure the type is sLink to increase id.
by Zhiyi Zhang (＠zhiyi) 10 Jul '23

10 Jul '23

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/syslink.c: > +static void test_GETSYSLINKID(void) > +{ > + HWND hwnd; > + int point; > + > + hwnd = create_syslink(WS_CHILD | WS_TABSTOP | WS_VISIBLE, hWndParent); > + ok(hwnd != NULL, "Failed to create SysLink window.\n"); > + > + /*the test point of link3(x=120 y=20).*/ > + point = ((20 << 16) | 120); > + > + SendMessageA(hwnd, WM_LBUTTONDOWN, 1, (LPARAM)point); > + > + g_linkid = 0; > + SendMessageA(hwnd, WM_LBUTTONUP, 0, (LPARAM)point); > + todo_wine ok(g_linkid == 2, "GETSYSLINKID was not processed correctly!\n"); Rename g_linkid to g_link_id. Rename the function to test_link_id(). Change this line to todo_wine ok(g_link_id == 2, "Got unexpected link id %d.\n", g_link_id); -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114#note_38453

1 0

2025

2024

2023

2022

wine-gitlab July 2023