On Mon Jul 10 16:57:51 2023 +0000, Alex Henrie wrote:
> If thread safety matters here, could you use strtok_r?
I'm not sure if it does, just wanted to make sure there is no race conditions. Not sure why I missed strtok_r, thanks.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_38565
I'm aware that winecfg allows unlinking of symlinked folders, but this is very annoying when regularly recreating WINEPREFIXES. This change makes it easy to isolate those folders from the start.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3259
> we should test the behavior of ctrl-c
I'm bit late to be reporting this :smile:, but Ctrl-C in (probably all) `-mwindows` Wine apps is now ignored (`winecfg`, `regedit`, etc). On the Windows apps side of things, at least Notepad++ also doesn't close on Ctrl-C.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38548
--
v4: vkd3d-shader/dxil: Read function bodies.
vkd3d-shader/dxil: Read numeric constants.
vkd3d-shader/dxil: Read global function declarations.
vkd3d-shader/dxil: Validate the module format version.
vkd3d-shader/dxil: Read the value symbol table.
vkd3d-shader/dxil: Read the type table.
vkd3d-shader/dxil: Use size_t where applicable.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/259
On Mon Jul 10 15:59:56 2023 +0000, Jakub Staroń wrote:
> It is indeed Wine-specific, but on Windows it isn't as much of a problem
> because AllocConsole gives you the same cmd you would use normally,
> while wineconsole is inferior to a normal terminal. Also is there any
> reason to explicitly block console output on GUI apps? If I understand
> it correctly on Windows it's done because otherwise a new console window
> is created, wine doesn't do that though?
all these four configurations should behave the same way regarding log output:
1) app on wine being run from a unix shell
2) app on wine being from with wineconsole
3) app on wine being run from a cmd window
4) app on windows being run from a cmd window
if you see a discrepancy in output between 2 of these four items, please report (or even better file a bug report)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38542
On Mon Jul 10 14:53:19 2023 +0000, Jacek Caban wrote:
> Is it some Wine-specific use case? I think that something like that
> would not work on Windows.
It is indeed Wine-specific, but on Windows it isn't as much of a problem because AllocConsole gives you the same cmd you would use normally, while wineconsole is inferior to a normal terminal. Also is there any reason to explicitly block console output on GUI apps? If I understand it correctly on Windows it's done because otherwise a new console window is created, wine doesn't do that though?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3145#note_38539