July 2023 - wine-gitlab

[PATCH 0/6] MR3261: Remove DECLSPEC_HIDDEN macro various dlls.
by Alistair Leslie-Hughes (＠alesliehughes) 07 Jul '23

07 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3261

4 8

Re: [PATCH v4 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Giovanni Mascellani (＠giomasce) 07 Jul '23

07 Jul '23

On Tue Jul 4 13:08:35 2023 +0000, Henri Verbeet wrote: > > The part that doesn't thrill me is the fact that DXGI still directly > accesses the VkQueue object, which I tend to see as an internal > implementation detail to vkd3d. On the other hand it's nice that we > don't need new API from vkd3d (even if, in the future, we were to need > something other than vkQueueSubmit() and vkQueuePresentKHR()). > For what it's worth, it was a fairly explicit design decision early on > to expose the underlying Vulkan objects for d3d12 devices and command > queues, as well as to allow the creation of d3d12 resources on top of > existing Vulkan images, for the purpose of interoperation with other > Vulkan code. I.e., the idea is that it should be possible to integrate > vkd3d into a larger Vulkan application to draw some parts using the > d3d12 API, while everything else is drawn using Vulkan. > The internal queueing of command queue operations on the vkd3d level is > unfortunate in that regard; ideally we just wouldn't do that. This MR > could probably do a better job of explaining why we need to do that in > some cases, and what kind of command queue operation sequences could > result in out-of-order presentation. > If we're going to need to introduce a DXGI worker thread anyway, could > we just make vkd3d_acquire_vk_queue() block until there are no longer > any operations queued? We already somewhat discussed that internally, but for the benefit of public archival the behavior of `vkd3d_acquire_vk_queue()` and `vkd3d_release_vk_queue()` was documented in https://gitlab.winehq.org/wine/vkd3d/-/commit/b2a1f6b5e4f59fbc7f91ada7e5656…. I'll implement the behavior recommended there in my next MR. The reason why it was decided to recommend to explicitly synchronize with an `ID3D12Fence` instead of making `vkd3d_acquire_vk_queue()` block until the queue is empty is because it is believed that the application is better than vkd3d at knowing how long it really makes sense to wait before actually acquiring the queue. In other words, `vkd3d_acquire_vk_queue()` doesn't know which queued operations are really required to be serialized with the queue acquisition. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_38301

1 0

[PATCH 0/3] MR3246: Better handling when debuggee terminates when attaching to it.
by eric pouech (＠epo) 07 Jul '23

07 Jul '23

This serie implements a more robust strategy when winedbg attaches to process which tries to terminate. This let --auto mode print some more information (and no longer crash) in such situation. Revamped also a bit information displayed in auto mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3246

3 5

[PATCH v4 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
by Mohamad Al-Jaf (＠maljaf) 07 Jul '23

07 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54699 I added the complete `windows.networking.idl` file since it was small and in case it's needed for mingw build. -- v4: windows.networking.hostname: Implement IHostName::get_RawName(). windows.networking.hostname: Implement IHostNameFactory::CreateHostName(). windows.networking.hostname/tests: Add IHostNameFactory::CreateHostName() tests. windows.networking.hostname: Add IHostNameFactory stub interface. windows.networking.hostname: Add stub DLL. include: Add windows.networking.idl file. include: Add windows.networking.connectivity.idl file. include: Add support for BYTE IReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/3249

4 14

Re: [PATCH v15 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Rémi Bernon (＠rbernon) 07 Jul '23

07 Jul '23

On Fri Jul 7 07:21:06 2023 +0000, Bernhard Kölbl wrote: > You could also add tests like in media.speech, where you try loading the > DLL via LoadLibraryW Sorry, I should've checked that. Fwiw if the module doesn't export anything in particular it should not really matter how it's named, the classes are registered with whatever module implements them and the code reads the module name from the registry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189#note_38294

1 0

Re: [PATCH v15 0/7] MR3189: Add windows.devices.geolocation.geolocator
by Bernhard Kölbl (＠besentv) 07 Jul '23

07 Jul '23

On Thu Jul 6 23:20:17 2023 +0000, Mohamad Al-Jaf wrote: > It's in the registry under > `HKEY_LOCAL_MACHINE\Software\Microsoft\WindowsRuntime\ActivatableClassId`. > It lists the classes there and if you click one there's a `DllPath` > string that contains the housing dll. You could also add tests like in media.speech, where you try loading the DLL via LoadLibraryW -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3189#note_38290

1 0

Re: [PATCH v6 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jul '23

07 Jul '23

On Mon Jul 3 10:04:03 2023 +0000, Davide Beatrici wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/3218/diffs?diff_id=55132&start_sha=a029ad6955486d1f4255b8af264e37bdef92075e#93e6661c548f95d6c2ae8340ba18809196820745_630_621) !3260 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3218#note_38286

1 0

Re: [PATCH v6 0/8] MR3218: wine{alsa,coreaudio,oss,pulse}: Move session_init_vols, create_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 07 Jul '23

07 Jul '23

On Mon Jul 3 10:04:02 2023 +0000, Davide Beatrici wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/3218/diffs?diff_id=55132&start_sha=a029ad6955486d1f4255b8af264e37bdef92075e#93e6661c548f95d6c2ae8340ba18809196820745_628_621) !3260 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3218#note_38284

1 0

[PATCH v37 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 07 Jul '23

07 Jul '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v37: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH v4 0/2] MR225: vkd3d-shader/tpf: Read complete swizzle/mask info from parameter tokens.
by Conor McCarthy (＠cmccarthy) 07 Jul '23

07 Jul '23

-- v4: vkd3d-shader/tpf: Read complete swizzle/mask info for dst params. vkd3d-shader/tpf: Read complete swizzle/mask info for src params. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/225

2 2

2025

2024

2023

2022

wine-gitlab July 2023