July 2023 - wine-gitlab

[PATCH v2 0/1] MR3058: kerberos: Avoid potentially uninitialized variable (clang-scan)
by Fabian Maurer (＠DarkShadow44) 06 Jul '23

06 Jul '23

When there are no caches, this variable would be uninitialized. Reported by clang-scan. Not sure if that can ever happen, but IMHO initializing doesn't do harm. -- v2: kerberos: Avoid potentially uninitialized variable (clang-scan) https://gitlab.winehq.org/wine/wine/-/merge_requests/3058

2 2

[PATCH 0/3] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) 06 Jul '23

06 Jul '23

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

3 11

[PATCH 0/3] MR3254: Remove DECLSPEC_HIDDEN for internet dll
by Alistair Leslie-Hughes (＠alesliehughes) 06 Jul '23

06 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3254

3 4

[PATCH v2 0/5] MR3256: Use nameless structs/unions for VARIANT struct (Clang build fixes)
by Jacek Caban (＠jacek) 06 Jul '23

06 Jul '23

Recent nameless struct/union changes broke MSVC Clang builds. That's because `VARIANT` still doesn't skip names when `__STDC__` is defined, which is true for most configs. -- v2: include: Don't force named VARIANT members when __STDC__ is defined. https://gitlab.winehq.org/wine/wine/-/merge_requests/3256

2 5

[PATCH v3 0/4] MR3234: winewayland.drv: part 5: window_surface flush optimizations
by Alexandros Frantzis (＠afrantzis) 06 Jul '23

06 Jul '23

This MR optimizes and makes correctness improvements to the window_surface flush implementation: 1. Implement a buffer queue to avoid constantly allocating new buffers. 2. Take into account the bounds of the window_surface flush and track per-buffer damage to reduce copying from the window_surface. 3. Copy from the window_surface only pixel data that lies within the flushed bounds. Maintain the latest contents for pixels outside these bounds, by copying them from the latest valid buffer. 4. Communicate damaged surface regions to the compositor to allow it to perform more efficient pixel data transfers (e.g., texture uploads). Thanks! -- v3: winewayland.drv: Send surface damage region to the compositor. winewayland.drv: Update only the flushed bounds from the window_surface. winewayland.drv: Track damaged buffer regions. winewayland.drv: Use a buffer queue for window_surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/3234

3 15

[PATCH 0/5] MR3256: Use nameless structs/unions for VARIANT struct (Clang build fixes)
by Jacek Caban (＠jacek) 06 Jul '23

06 Jul '23

Recent nameless struct/union changes broke MSVC Clang builds. That's because `VARIANT` still doesn't skip names when `__STDC__` is defined, which is true for most configs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3256

3 8

[PATCH v2 0/2] MR266: Document vkd3d_acquire_vk_queue() and vkd3d_release_vk_queue().
by Giovanni Mascellani (＠giomasce) 06 Jul '23

06 Jul '23

-- v2: demos: Use a fence to synchronize D3D12 and Vulkan work. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/266

3 4

[PATCH 0/1] MR262: vkd3d: Make CopyResource use a temp buffer for depth <-> color copies
by Evan Tang (＠etang-cw) 06 Jul '23

06 Jul '23

depth <-> color copies aren't allowed in Vulkan Uses the same handling as `CopyTextureRegion` to perform the copy -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/262

4 4

[PATCH 0/1] MR3247: d3d11/tests: Add basic test for shared resources.
by Paul Gofman (＠gofman) 06 Jul '23

06 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3247

3 2

[PATCH v2 0/10] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon (＠rbernon) 06 Jul '23

06 Jul '23

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- v2: mf/tests: Add more media session transform tests with multiple inputs. mf/tests: Add more media session transform tests with multiple outputs. mf/tests: Add some media session transform call pattern tests. mf/session: Increase the stream request count when requests are already queued. mf/session: Request more samples from upstream when necessary. mf/session: Push transform input samples one by one to ProcessInput. mf/session: Use helpers to push and pop samples for transform streams. mf/session: Flush requests in transform_node_deliver_samples when drained. mf/session: Use a helper to deliver transform node requested samples. mf/session: Use local variables to access transform node streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

3 12

2025

2024

2023

2022

wine-gitlab July 2023