August 2023 - wine-gitlab

[PATCH v6 0/9] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.
by Francisco Casas (＠fcasas) 03 Aug '23

03 Aug '23

Recap: I implemented relative addressing in !229, but I was suggested to handle register indexes by moving all the registers to the heap, which I did in my [nonconst-offsets-6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/noncon… branch. A part of this implementation required !269, but I was asked to try to turn the sm4 register structs into the vkd3d-shader register structs instead, to get closer to a common low level IR. This is the first part of that transformation. The whole thing is in my [use_vkd3d_reg_4](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/use_vkd3d… branch. ~~This is built on top of !225 (the first two patches), so it may be good to get that upstream first.~~ --- This patch series aims to do the following replacements: ``` struct sm4_register -> struct vkd3d_shader_register struct sm4_dst_register -> struct vkd3d_shader_dst_param struct sm4_src_register -> struct vkd3d_shader_src_param ``` to get us closer to a common level IR and simplify the implementation of relative-addressing. To achieve this, the fields in the sm4 register structs are replaced with fields in the vkd3d-shader structs or removed altogether, one at the time. As can be seen when looking at the whole branch, it is possible to do this transformation without having to add additional fields to `struct vkd3d_shader_register`, by restricting each register type to a single `enum vkd3d_sm4_dimension` (and its src registers to a single `enum vkd3d_sm4_swizzle_type`) by default. The only exception we need so far is for sampler registers: They always have dimension NONE, except when used as arguments of gather instructions, in which case they have dimension VEC4 and SCALAR swizzle. This, and similar exceptions we may find in the future, can be handled using the opcode_info, as in 7/8 [81e17506](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/81e17506ba2cb1fbf…. -- v6: vkd3d-shader/tpf: Get rid of sm4_register.dim. vkd3d-shader/tpf: Use 's' in src_info to expect sampler register with vec4 dimension. vkd3d-shader/tpf: Separate dst register write function. vkd3d-shader/tpf: Separate src register write function. vkd3d-shader/tpf: Make register_type_table an array of structs with lookup tables. vkd3d-shader/tpf: Introduce struct tpf_writer to group sm4 write arguments. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281

2 11

[PATCH 0/1] MR3495: ntdll: Add semi-stub for NtOpenKeyTransactedEx.
by Etaash Mathamsetty (＠etaash.mathamsetty) 02 Aug '23

02 Aug '23

Something seems to be calling this in the new wow64 mode -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3495

2 1

Re: [PATCH v2 0/1] MR3360: shell32: Improve shell copy and delete items functions, notifications.
by Huw Campbell (＠HuwCampbell) 02 Aug '23

02 Aug '23

On Wed Aug 2 20:04:56 2023 +0000, Bernhard Kölbl wrote: > Since no one answered, yet: > 1. IIRC we don't want ReactOS code in Wine, as it might be reverse engineered. > 2. This very likely needs tests. I wrote the functions in question here first; and also put up a PR over there with a modified version of it. I can think about some tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3360#note_41123

1 0

[PATCH v4 0/1] MR3458: ddraw/tests: Fix overflow bugs in compare_float.
by Jeffrey Smith (＠whydoubt) 02 Aug '23

02 Aug '23

1. Subtracting integers may result in an overflow or underflow. 2. Right at the 'edge' of underflowing, the result of subtraction may be `INT_MIN`, and the call to `abs()` will also result in `INT_MIN`. This fix accounts for all of these conditions. EXAMPLES: 1. can be encountered by comparing 2.0 and -2.0 2. can be encountered by comparing -2.0 and 2.0 NOTE: There are 14 more instances of `compare_float` across several modules. I would like to make sure the logic is sound with this MR, then I can take on the rest. -- v4: ddraw/tests: Use compare_uint() in compare_float() instead of abs(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3458

4 3

[PATCH 0/2] MR3476: quartz: Fix some memory leaks
by Sven Baars (＠sbaars) 02 Aug '23

02 Aug '23

After reading !3386 I thought I'd have a look. There are a ton more, but we have to start somewhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3476

3 3

[PATCH 0/2] MR3493: qcap/audiorecord: Enumerate the currently set media type first.
by Zebediah Figura (＠zfigura) 02 Aug '23

02 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3493

2 2

Re: [PATCH v2 0/1] MR3360: shell32: Improve shell copy and delete items functions, notifications.
by Bernhard Kölbl (＠besentv) 02 Aug '23

02 Aug '23

On Wed Aug 2 20:04:56 2023 +0000, Huw Campbell wrote: > I had a review from the ReactOS guys with some suggestions, but before I > make them is there any interest in taking up maintenance changes like > the for the shell? > Who should I ping for a review? Since no one answered, yet: 1. IIRC we don't want ReactOS code in Wine, as it might be reverse engineered. 2. This very likely needs tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3360#note_41115

1 0

[PATCH 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
by Bernhard Kölbl (＠besentv) 02 Aug '23

02 Aug '23

Today, if media_source_Shutdown is called around the same time as a work item is put on the async_commands_queue, we end up in a deadlock if Shutdown enters media source's cs first, as it waits for the queue's callback to finish, which, in turn, waits for the object's cs to be released. To avoid this leave the cs, before unlocking the workqueue, to let any callback on the queue finish running. Signed-off-by: Bernhard Kölbl <bkoelbl(a)codeweavers.com> Blocks !3351 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3491

2 1

[PATCH v3 0/2] MR2853: Draft: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 02 Aug '23

02 Aug '23

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v3: win32u: Implement EVENT_SYSTEM_FOREGROUND. user32: Run tests that notice focus changes early. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 10

[PATCH 0/1] MR3485: msxml3/tests: Use wide strings to generate BSTRs in schema.c.
by Michael Stefaniuc (＠mstefani) 02 Aug '23

02 Aug '23

Gets rid of an a2bstr() like helper. _bstr_() helper is kept as it is used to simplify the clean up of the generated BSTRs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3485

3 3

2025

2024

2023

2022

wine-gitlab August 2023