August 2023 - wine-gitlab

[PATCH v6 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 17 Aug '23

17 Aug '23

I have covered implementation with additional test cases. -- v6: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

4 3

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

I think it's better to have media engine patches in a separate MR, after making sure they work on Windows first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42634

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > } > } > > + if (session->state == SESSION_STATE_STARTED) > + { > + session_flush_transform_output_nodes(session); > + session_set_source_output_nodes_seeking(session); > + } Same here, isn't it possible to seek from paused state too? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42633

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > > /* fallthrough */ > case SESSION_STATE_PAUSED: > + case SESSION_STATE_STARTED: > + if (session->state == SESSION_STATE_STARTED && !(session->caps & MFSESSIONCAP_SEEK)) > + { > + WARN("Seeking is not supported for this session.\n"); > + session_command_complete(session); > + return; > + } Why does it check for STARTED state? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42632

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > return hr; > } > > +static void session_flush_transform_output_nodes(struct media_session *session) This could be call session_flush_nodes(), or flush_topology/flush_pipeline, no need to make the name that specific. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42631

1 0

[PATCH 0/1] MR3587: mshtml: Make skip_prefix static in OmNavigator_get_appVersion.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3587

4 6

[PATCH v6 0/3] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) 17 Aug '23

17 Aug '23

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v6: add a skip log when there is no simsun font in test env. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

3 5

[PATCH v2 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- v2: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

2 2

[PATCH v4 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

-- v4: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

3 9

[PATCH 0/5] MR3596: Win10 evolution for OutputDebugStringW.
by eric pouech (＠epo) 17 Aug '23

17 Aug '23

Win10 introduced the ability for OutputDebugStringW to send Unicode strings (instead of translating the Unicode string to ANSI and call OutputDebugStringA). This series: - add a couple of tests for covering various aspects + how exception with unicode string is constructed, + interaction with WaitForDebugEvent and WaitForDebugEventEx - implements WaitForDebugEventEx() - emit unicode string from OutputDebugStringW - introduce manifest constants to describe stages in exception testing (this let adding new stages way easier). Note this has not been tested on ARM. The tests results are not fully green because of existing issues in ntdll:exception (see https://bugs.winehq.org/show_bug.cgi?id=55111 for win8 and early win10, and all the failing ones in Win11...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3596

3 7

2025

2024

2023

2022

wine-gitlab August 2023