August 2023 - wine-gitlab

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/pathiterator.c: > GpPath *path; > GpPathIterator *iter; > GpStatus stat; > - INT start, end, result; > + INT count, start, end, result, closed; Again, `BOOL closed;` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42604

1 0

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

On Wed Aug 16 21:48:02 2023 +0000, Bartosz Kosiorek wrote: > How it could be done (set \*result when you return)? I just mean set *result before you return, just like you do about 5 lines before. It appears 0 would the appropriate value, in which case you could combine the if blocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42603

1 0

[PATCH v5 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 17 Aug '23

17 Aug '23

Previously, clearing the current render target would delay the clear until the render pass was ended by something else Fixes missing UI in [Moving Out](https://store.steampowered.com/app/996770/Moving_Out/) -- v5: wined3d: Restart vk render pass on RT clear. d3d11: Add tests for clearing RTs in the middle of a render. https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

4 5

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/pathiterator.c: > GpPath *path; > GpPathIterator *iter; > GpStatus stat; > - INT start, end, result; > - BOOL closed; > + INT start, end, result, closed; I would leave the type as BOOL, to make it match the 4th parameter of GdipPathIterNextSubpath. But since it is implemented as an integer (as opposed to an actual boolean that only accepts true/false), it can contain any value that an INT can, so the tests should still be fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42601

1 0

[PATCH 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

3 2

[PATCH v3 0/2] MR3578: freopen() fix.
by eric pouech (＠epo) 17 Aug '23

17 Aug '23

I stumbled onto this while using freopen() for debugging purposes. Basically, freopen() fails if the FILE has been created with an invalid handle. So, this MR contains: - basic tests for freopen (no issue there, just for coverage purposes) - tests for freopen on FILE with invalid handle - fix for freopen -- v3: msvcrt: Fix freopen() on FILE with invalid underlying fd. msvcrt/tests: Add tests for freopen(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3578

3 4

[PATCH 0/1] MR3584: joy: Remove size argument to set_config_key function.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Having to pass the size separately made the function unnecessarily complicated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3584

4 3

[PATCH 0/1] MR3595: mf: Implement MFCreateSequencerSegmentOffset().
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3595

2 1

Re: [PATCH v2 0/1] MR3577: ieframe/tests: Use less strict checks in session count tests.
by Francois Gouget (＠fgouget) 17 Aug '23

17 Aug '23

On Wed Aug 16 20:20:19 2023 +0000, Jacek Caban wrote: > One way or another, tests of a global state like that will always be > theoretically a subject to race. In essence, my patch reduces problem > probability, just like your solution. Which is why a general solution would be better than N different hacks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3577#note_42592

1 0

[PATCH v2 0/7] MR3552: include: Add WinRT applicationmodel definitions.
by Mohamad Al-Jaf (＠maljaf) 17 Aug '23

17 Aug '23

-- v2: include: Add IStorageFolder interface definition. include: Add windows.storage.search.idl file. include: Add IStorageItem interface definition. include: Add windows.storage.fileproperties.idl file. include: Add IStorageFile interface definition. include: Add IRandomAccessStream interface definition. include: Add IPackageStatics interface definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/3552

3 10

2025

2024

2023

2022

wine-gitlab August 2023