It's possible that a state object pointer not in the topology node collection gets passed to
session_get_node_object(). Instead of returning the last node when the object is not found, we
should return a NULL so that the state of the last node is not changed by mistake.
--
v8: mf/tests: Test IMFMediaSession::Start().
mf: Add seeking support for IMFMediaSession::Start().
mf/tests: Add a create_test_topology() helper.
mf: Add a session_flush_nodes() helper.
mf: Make session_get_node_object() more robust.
mf: Avoid a double free of presentation clock timers.
https://gitlab.winehq.org/wine/wine/-/merge_requests/3572
On Wed Sep 27 02:39:04 2023 +0000, Zhiyi Zhang wrote:
> I doubt it's returning true even when a light theme is on. Please add
> some tests for this function. In the test, you can get the function
> pointer from ordinal. Also, could you point me to that .NET source code
> that uses this function?
There is also a WinRT dark theme option in winecfg. I think you can use that to report whether to return true in this function. See 3503ab4. In the test, you can test if the AppsUseLightTheme registry value corresponds to the return value of this function.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_46915
Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c:
> UnregisterUserApiHook();
> return TRUE;
> }
> +
> +/**********************************************************************
> + * ShouldUseDarkMode (UXTHEME.138)
> + *
> + * RETURNS
> + * whether or not the app should use dark mode (true for most)
> + */
> +BOOL WINAPI ShouldUseDarkMode(void)
> +{
> + return TRUE;
I doubt it's returning true even when a light theme is on. Please add some tests for this function. In the test, you can get the function pointer from ordinal. Also, could you point me to that .NET source code that uses this function?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_46914