On Wed Sep 27 02:39:04 2023 +0000, Zhiyi Zhang wrote:
> I doubt it's returning true even when a light theme is on. Please add
> some tests for this function. In the test, you can get the function
> pointer from ordinal. Also, could you point me to that .NET source code
> that uses this function?
There is also a WinRT dark theme option in winecfg. I think you can use that to report whether to return true in this function. See 3503ab4. In the test, you can test if the AppsUseLightTheme registry value corresponds to the return value of this function.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_46915
Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c:
> UnregisterUserApiHook();
> return TRUE;
> }
> +
> +/**********************************************************************
> + * ShouldUseDarkMode (UXTHEME.138)
> + *
> + * RETURNS
> + * whether or not the app should use dark mode (true for most)
> + */
> +BOOL WINAPI ShouldUseDarkMode(void)
> +{
> + return TRUE;
I doubt it's returning true even when a light theme is on. Please add some tests for this function. In the test, you can get the function pointer from ordinal. Also, could you point me to that .NET source code that uses this function?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_46914