September 2023 - wine-gitlab

[PATCH v5 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 13 Sep '23

13 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v5: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

4 10

[PATCH 0/2] MR3806: combase/roapi: Initialize implicit MTA in RoGetActivationFactory().
by Paul Gofman (＠gofman) 13 Sep '23

13 Sep '23

Fixes Starfield not being able to take photos in photo mode (due to failing to creating windowscodecs' image factory due to COM apartment being initialized). Turns out on Windows RoGetActivationFactory() initializes implicit MTA apartment when called from STA thread, and so after that called once COM is implicitly uninitialized for any (new) thread until COM is uninitialized in the thread which called RoGetActivationFactory (or that thread exited). This is not the case on Win8 (where the function was first introduced) but looks consistent after that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3806

3 3

[PATCH v6 0/2] MR3566: server: Store both contexts in pending context object.
by Jacek Caban (＠jacek) 13 Sep '23

13 Sep '23

And discard irrelevant parts in select request. We currently store something in CTX_PENDING and ignore it later in select request if we're currently running in wow context. -- v6: ntdll/tests: Add tests for setting context on unsuspended thread. server: Store both contexts in pending context object. https://gitlab.winehq.org/wine/wine/-/merge_requests/3566

2 3

[PATCH v10 0/7] MR3799: kernelbase: Add implementation of PerfSetULongCounterValue and PerfSetULongLongCounterValue
by Lorenzo Ferrillo (＠llde) 13 Sep '23

13 Sep '23

These functions are used by Visual Studio 2019, when opening or converting some projects. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v10: kernelbase: Check for PERF_SIZE_LARGE in PerfSetULongLongCounterValue and PerfSetULongCounterValue kernelbase : Check for PERF_ATTRIB_BY_REFERENCE attribute in PerfSetCounterRefValue advapi/test: Add Test For PerfSetULongLongCounterValue advapi32/tests: Create Tests for PerfSetULongCounterValue advapi32: Forward PerfSetULongCounterValue and PerfSetULongLongCounterValue to kernelbase kernelbase: Add implementation for PerfSetULongLongCounterValue kernelbase: Add implementation of PerfSetULongCounterValue https://gitlab.winehq.org/wine/wine/-/merge_requests/3799

2 8

[PATCH 0/1] MR3809: d3dxof: Remove unnecessary includes.
by Zebediah Figura (＠zfigura) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3809

4 4

[PATCH 0/4] MR337: tests: Compile HLSL shaders at runtime.
by Giovanni Mascellani (＠giomasce) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/337

3 6

[PATCH 0/1] MR340: vkd3d-shader/hlsl: Document some possibly obscure HLSL opcodes.
by Giovanni Mascellani (＠giomasce) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/340

3 4

[PATCH 0/5] MR3813: Decl misc
by Alistair Leslie-Hughes (＠alesliehughes) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3813

2 5

[PATCH v5 0/1] MR3767: msvcp110: Add std::_Throw_future_error.
by Daniel Lehman (＠dlehman25) 13 Sep '23

13 Sep '23

-- v5: msvcp110: Add std::_Throw_future_error. https://gitlab.winehq.org/wine/wine/-/merge_requests/3767

3 2

Re: [PATCH v6 0/1] MR3736: winmm: Use CRT allocation functions.
by Huw Davies (＠huw) 13 Sep '23

13 Sep '23

> it's necessary to cast the pointers returned from malloc and realloc here because we add 1 to the pointer before assigning it to a variable. It's unusual but it works. Still, we could simplify this code a bit by only calling realloc. Right, sorry about that. However, let's start off with a commit that makes this explicit, to avoid mistakes by future reviewers. Something like: ```c if (llTypes[type].lpMlds) { WINE_MLD *mem = llTypes[type].lpMlds - 1; mem = HeapReAlloc(GetProcessHeap(), 0, mem, sizeof(WINE_MLD) * (llTypes[type].wMaxId + 1)); llTypes[type].lpMlds = mem + 1; } else { WINE_MLD *mem; mem = HeapAlloc(GetProcessHeap(), 0, sizeof(WINE_MLD) * (llTypes[type].wMaxId + 1)); llTypes[type].lpMlds = mem + 1; } ``` Then we can merge to two branches into `realloc()` in the commit that switches things to the CRT allocator. > As far as the casts in the calls to free, they are all to avoid warnings about freeing pointers to const strings, so they can't be removed. Got it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3736#note_45151

1 0

2025

2024

2023

2022

wine-gitlab September 2023