January 2024 - wine-gitlab

[PATCH v7 0/2] MR4822: ntdll: Fix: Ignore alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 10 Jan '24

10 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually exactly how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. -- v7: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

3 3

[PATCH v5 0/2] MR4822: ntdll: Fix: Ignore alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 10 Jan '24

10 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually exactly how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. -- v5: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

3 4

[PATCH 0/3] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) 10 Jan '24

10 Jan '24

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 3

[PATCH v6 0/2] MR4822: ntdll: Fix: Ignore alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 10 Jan '24

10 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually exactly how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. -- v6: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

2 2

Re: [PATCH v2 0/1] MR4819: ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver.
by Zebediah Figura (＠zfigura) 10 Jan '24

10 Jan '24

That doesn't mean that everything's uninstalled properly on windows 7/8, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4819#note_57118

1 0

Re: [PATCH v2 0/1] MR4819: ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver.
by Rémi Bernon (＠rbernon) 10 Jan '24

10 Jan '24

The test is working fine without the flag on Win10, so I'm assuming everything is uninstalled properly, like I also confirmed manually many times when I worked on the dinput tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4819#note_57117

1 0

[PATCH v4 0/1] MR4822: ntdll: Fix: Ignore alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 10 Jan '24

10 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually exactly how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. -- v4: ntdll: Fix: Ignore alignment if MEM_REPLACE_PLACEHOLDER is set in flags https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

4 4

Re: [PATCH v2 0/1] MR4819: ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver.
by Zebediah Figura (＠zfigura) 10 Jan '24

10 Jan '24

How do we know this isn't hiding some other bug? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4819#note_57115

1 0

Re: [PATCH v2 0/1] MR4819: ntoskrnl.exe/tests: Use SUOI_FORCEDELETE when uninstalling the driver. - approved
by Alexandre Julliard (＠julliard) 10 Jan '24

10 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4819

1 0

Re: [PATCH v2 0/1] MR4818: wldap32/tests: Skip tests when the server can't be reached. - approved
by Alexandre Julliard (＠julliard) 10 Jan '24

10 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4818

1 0

2025

2024

2023

2022

wine-gitlab January 2024