January 2024 - wine-gitlab

[PATCH 0/1] MR558: vkd3d-shader/hlsl: Emit fixmes on non-constant vector addressing.
by Francisco Casas (＠fcasas) 11 Jan '24

11 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56162 Storing to a vector component using a non-constant index is not allowed on profiles lower than 6.0. Unless this happens inside a loop that can be unrolled, which we are not doing yet. For this reason, a validate_nonconstant_vector_store_derefs pass is added to check whether there is a non-constant index on a vector on the lhs of a load. Ideally we would want to emit an hlsl_error on this pass, but we before implementing loop unrolling, we could reach this point on valid HLSL. Also, as pointed out by @nsivov in the mentioned bug, currently new_offset_from_path_index() fails an assertion when this happens, because it expects an hlsl_ir_constant, so a check is added. It also felt correct to emit an hlsl_fixme there, despite the redundancy. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/558

2 1

[PATCH v4 0/1] MR4823: winex11: Move the update_desktop_fullscreen callsite to update_net_wm_states.
by Gabriel Ivăncescu (＠insn) 11 Jan '24

11 Jan '24

Apparently, this wasn't enough to fix it in all WMs. It's simpler to just use the same sequence as normal fullscreen windows and avoid headaches with virtual desktops, and Béla reported it working as well (I couldn't reproduce it, but nothing broke for me, at least). I know the whole NtUserGetPrimaryMonitorRect thing is wrong and only works for one monitor, but that was already the case before, so I kept it the same since it won't fix a regression and we're in code freeze. -- v4: winex11: Move the update_desktop_fullscreen callsite to update_net_wm_states. https://gitlab.winehq.org/wine/wine/-/merge_requests/4823

3 2

[PATCH 0/3] MR557: vkd3d-shader/dxbc: Avoid DWORDs.
by Henri Verbeet (＠hverbeet) 11 Jan '24

11 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/557

2 3

[PATCH v2 0/1] MR555: vkd3d-shader/dxil: Avoid null dereference on failure to find function pointer type.
by Conor McCarthy (＠cmccarthy) 11 Jan '24

11 Jan '24

-- v2: vkd3d-shader/dxil: Avoid null dereference on failure to find function pointer type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/555

3 2

[PATCH 0/1] MR554: vkd3d-shader: Make *src and *dst mutable in vkd3d_shader_instruction.
by Giovanni Mascellani (＠giomasce) 11 Jan '24

11 Jan '24

They were originally made const because no optimization/normalization pass existed. Now having to cast away const all the time is becoming more and more burdening. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/554

3 3

[PATCH 0/4] MR552: vkd3d-shader/spirv: Avoid DWORDs.
by Henri Verbeet (＠hverbeet) 11 Jan '24

11 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/552

3 6

[PATCH 0/1] MR551: vkd3d-shader: Recognise DESCRIPTORS_STATIC_KEEPING_BUFFER_BOUNDS_CHECKS in shader_validate_descriptor_range1().
by Henri Verbeet (＠hverbeet) 11 Jan '24

11 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/551

3 3

[PATCH v18 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 11 Jan '24

11 Jan '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v18: vkd3d-shader/tpf: Add initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

3 9

[PATCH 0/5] MR550: vkd3d-shader/ir: Validate SSA and TEMP usages.
by Giovanni Mascellani (＠giomasce) 11 Jan '24

11 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/550

3 9

[PATCH 0/17] MR541: RFC: Shader cache for vkd3d
by Stefan Dösinger (＠stefan) 11 Jan '24

11 Jan '24

Here is a preview of my shader cache work for early comments. It isn't complete, but does successfully cache things. What's there: * A new vkd3d API that is used internally for caching, can be used to implement the ID3D12ShaderCacheSession interface and hopefully be used by wined3d as well * Simple saving and loading of the cached objects * It is used to cache render passes, root signatures and pipeline states What is not yet there * Partial cache loading and eviction * ID3D12ShaderCacheSession - largely because it needs bumping ID3D12Device up to version 9, which may bring unrelated regressions. For this and tests see my "cache-rework" branch (which * Cache file compression * Incremental updates of cache files - right now they are rewritten from scratch on exit * Loading the cache in an extra thread. The pipeline state creation code will need some refactor for that I am not quite happy yet with the two patches that write and reload actual graphics pipelines. The way I am storing the d3d settings aren't quite consistent yet either - in some cases I use the d3d input data as key directly, in others I store them as values attached to a hash value. The latter is usually the case if I need to cross-reference something, e.g. have a link from the pipeline state to the root signature. This kind of setup shows how wined3d can build a chain of linked state though. There are also known issues with locking, explained in comments in the patches. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/541

6 50

2025

2024

2023

2022

wine-gitlab January 2024