First change is to avoid creating and mapping windows concurrently, this is completely racy and can cause random results later on depending on which window ends up being focused and depending on the X11 events. In addition, FVWM focus tracking suffers from various race conditions already, which only makes it worse.
Second change is to avoid failing the tests because of spurious window resize messages on the dummy window. I'm not sure what the window is for exactly but I believe it's not meaningful in the message sequence as it never appears there. As it is maximized, the window is sometimes resized by some WMs when the display mode changes, which cause the spurious WM_SIZE messages.
--
v3: d3d8/tests: Use static class for the dummy window.
d3d8/tests: Avoid creating visible windows concurrently.
d3d9/tests: Use static class for the dummy window.
d3d9/tests: Avoid creating visible windows concurrently.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6700
On Thu Oct 24 16:32:46 2024 +0000, Vijay Kiran Kamuju wrote:
> changed this line in [version 28 of the diff](/wine/wine/-/merge_requests/4661/diffs?diff_id=139983&start_sha=704c7862cdae2a5c380fe8e52a0889864ffbb9e6#02bb3b4ad98d91472456efe7c9f200666067cf8d_5682_5665)
I removed the GdipSetEffectParameters implementation till tests are working.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_85981
On Thu Oct 24 16:32:46 2024 +0000, Vijay Kiran Kamuju wrote:
> changed this line in [version 28 of the diff](/wine/wine/-/merge_requests/4661/diffs?diff_id=139983&start_sha=704c7862cdae2a5c380fe8e52a0889864ffbb9e6#02bb3b4ad98d91472456efe7c9f200666067cf8d_5682_5665)
I removed the GdipSetEffectParameters implementation till tests are working.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_85980
On Thu Oct 24 16:32:45 2024 +0000, Vijay Kiran Kamuju wrote:
> changed this line in [version 28 of the diff](/wine/wine/-/merge_requests/4661/diffs?diff_id=139983&start_sha=704c7862cdae2a5c380fe8e52a0889864ffbb9e6#02bb3b4ad98d91472456efe7c9f200666067cf8d_5676_5665)
I removed the GdipSetEffectParameters implementation till tests are working.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_85979
On Thu Oct 24 16:32:45 2024 +0000, Vijay Kiran Kamuju wrote:
> changed this line in [version 28 of the diff](/wine/wine/-/merge_requests/4661/diffs?diff_id=139983&start_sha=704c7862cdae2a5c380fe8e52a0889864ffbb9e6#7c8ca2b5a97a42676b2979286a5fe74c047f321f_5537_5441)
I removed the implementation of GdipSetEffectParameters.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_85978
On Thu Oct 24 16:32:44 2024 +0000, Vijay Kiran Kamuju wrote:
> changed this line in [version 28 of the diff](/wine/wine/-/merge_requests/4661/diffs?diff_id=139983&start_sha=704c7862cdae2a5c380fe8e52a0889864ffbb9e6#02bb3b4ad98d91472456efe7c9f200666067cf8d_5668_5665)
I removed the implementation for GdipSetEffectParameters, till I can perfect the tests.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_85977
On Thu Oct 24 17:14:33 2024 +0000, Vijay Kiran Kamuju wrote:
> I have changed the structure a bit to fix a bit of issues
I removed the implementation of GdipSetEffectParameters, till I can perfect the tests for it.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_85976