October 2024 - wine-gitlab

[PATCH v2 0/2] MR6696: mciseq: Don't seek to the end of the root chunk in RMID files.
by Sebastian Krzyszkowiak (＠dos1) 21 Oct '24

21 Oct '24

Commit 9e1008f13735 added mmioSeek call that skips the whole data portion of the RMID chunk, breaking the handling of RMID (RIFF-based MIDI) files as it effectively skips the whole content of the RIFF file. Since mmioDescend expects the file position to be somewhere within the specified parent chunk, it's guaranteed to fail. $ WINEDEBUG=+mcimidi wine wintest.exe mcishell mci.c:178: Type your commands to the MCI, end with Ctrl-Z/^D open BOSSNOVA.RMI mci.c:188: command: open BOSSNOVA.RMI 0764:trace:mcimidi:MIDI_mciOpen (1, 00000200, 0051FB98) 0764:trace:mcimidi:MIDI_mciOpen wDevID=1 (lpParams->wDeviceID=1) 0764:trace:mcimidi:MIDI_mciOpen MCI_OPEN_ELEMENT L"bossnova.rmi"! 0764:trace:mcimidi:MIDI_mciOpen hFile=00000001 0764:trace:mcimidi:MIDI_mciOpen ParentChunk ckid=RIFF fccType=RMID cksize=000052DA mci.c:191: Test failed: mci open BOSSNOVA.RMI error: 296(40 MCIERR_INVALID_FILE) Its introduction seems unrelated to the rest of that commit and there's no reason given for placing it there, so let's remove the mmioSeek call to fix RMID file handling in MCI. Previous mmioDescend call will set the position to just after the chunk's form type, which is exactly where it should be when calling mmioDescend the second time to find the data chunk. Other parts of Wine code that deal with RIFF files don't seek in analogous situations either. Fixes: 9e1008f13735 ("Removed fixed size array to store specific data") -- v2: mciseq: Don't seek to the end of the root chunk in RMID files. midiseq: Reduce race window when closing sequencer. https://gitlab.winehq.org/wine/wine/-/merge_requests/6696

5 6

[PATCH v2 0/7] MR6703: msvcrt: Improve DBCS support for _strnicmp_l().
by Jactry Zeng (＠jactry) 20 Oct '24

20 Oct '24

-- v2: msvcrt/tests: Add tests of _strnicmp_l(). include: Add _strnicmp_l() declaration. msvcrt/tests: Test _stricmp() with multiple bytes characters. msvcrt: Improve DBCS support for _strnicmp_l(). msvcrt/tests: Test _tolower_l() with DBCS. msvcrt: Improve DBCS support for _tolower_l(). msvcrt/tests: Test tolower() with DBCS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6703

5 17

[PATCH 0/5] MR6703: msvcrt: Improve DBCS support for _strnicmp_l().
by Jactry Zeng (＠jactry) 20 Oct '24

20 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6703

4 7

[PATCH 0/1] MR6696: mciseq: Don't seek to the end of the root chunk in RMID files.
by Sebastian Krzyszkowiak (＠dos1) 19 Oct '24

19 Oct '24

Commit 9e1008f13735 added mmioSeek call that skips the whole data portion of the RMID chunk, breaking the handling of RMID (RIFF-based MIDI) files as it effectively skips the whole content of the RIFF file. Since mmioDescend expects the file position to be somewhere within the specified parent chunk, it's guaranteed to fail. $ WINEDEBUG=+mcimidi wine wintest.exe mcishell mci.c:178: Type your commands to the MCI, end with Ctrl-Z/^D open BOSSNOVA.RMI mci.c:188: command: open BOSSNOVA.RMI 0764:trace:mcimidi:MIDI_mciOpen (1, 00000200, 0051FB98) 0764:trace:mcimidi:MIDI_mciOpen wDevID=1 (lpParams->wDeviceID=1) 0764:trace:mcimidi:MIDI_mciOpen MCI_OPEN_ELEMENT L"bossnova.rmi"! 0764:trace:mcimidi:MIDI_mciOpen hFile=00000001 0764:trace:mcimidi:MIDI_mciOpen ParentChunk ckid=RIFF fccType=RMID cksize=000052DA mci.c:191: Test failed: mci open BOSSNOVA.RMI error: 296(40 MCIERR_INVALID_FILE) Its introduction seems unrelated to the rest of that commit and there's no reason given for placing it there, so let's remove the mmioSeek call to fix RMID file handling in MCI. Previous mmioDescend call will set the position to just after the chunk's form type, which is exactly where it should be when calling mmioDescend the second time to find the data chunk. Other parts of Wine code that deal with RIFF files don't seek in analogous situations either. Fixes: 9e1008f13735 ("Removed fixed size array to store specific data") -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6696

3 3

[PATCH 0/1] MR6702: include: Add new property keys in propkey.h.
by Biswapriyo Nath (＠Biswa96) 19 Oct '24

19 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6702

3 3

Re: [PATCH v3 0/1] MR6674: xml2: Import upstream release 2.12.8.
by darkblaze69 (＠darkblaze69) 19 Oct '24

19 Oct '24

Office 2013 setup fails since this commit ![Screenshot_From_2024-10-19_11-18-54](/uploads/89b3c675a00c707dfc330232baa2afbe/Screenshot_From_2024-10-19_11-18-54.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6674#note_85508

1 0

[PATCH 0/5] MR6681: dplayx, dpwsockx: CreatePlayer() part 2.
by Anton Baskanov (＠baskanov) 19 Oct '24

19 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6681

4 10

[PATCH v3 0/1] MR6662: win32u/zibdrv: Round get_arc_max_points() value to a multiple of 4.
by Aida Jonikienė (＠DodoGTA) 19 Oct '24

19 Oct '24

This seems like a weird solution to me (so I'm not sure if the tests pass) -- v3: win32u/dibdrv: Round get_arc_max_points() value to a multiple of 4. https://gitlab.winehq.org/wine/wine/-/merge_requests/6662

3 6

[PATCH v2 0/1] MR6693: mlang: Only consider true type fonts in map_font().
by Danyil Blyschak (＠blyss) 18 Oct '24

18 Oct '24

-- v2: mlang: Only consider true type fonts in map_font(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6693

3 2

Re: [PATCH v4 0/6] MR6688: d3dx9: Move targa decoding into d3dx9, part 2. - approved
by Alexandre Julliard (＠julliard) 18 Oct '24

18 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6688

1 0

2025

2024

2023

2022

wine-gitlab October 2024