November 2024 - wine-gitlab

[PATCH v2 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour, and update tests accordingly
by Eugene McArdle (＠eugenemcardle) 29 Nov '24

29 Nov '24

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This test has been updated to only allow current Windows behaviour, and `NtQueryDirectoryFile` will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE` as appropriate. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. -- v2: ntdll: Test updated NtQueryDirectoryFile behaviour if scan is reset with a new mask ntdll: Update NtQueryDirectoryFile to purge cache if scan is reset with a new mask https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

2 3

[PATCH 0/1] MR6740: include: Add windows.graphics.directx.direct3d11.interop.h
by Biswapriyo Nath (＠Biswa96) 28 Nov '24

28 Nov '24

Required for https://webrtc.googlesource.com/src/+/2aad81259ef832172d65aeaba6401fee857a0… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6740

3 3

Re: [PATCH v8 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef - closed
by Ostap Brehin (＠osbre) 28 Nov '24

28 Nov '24

This merge request was closed by Ostap Brehin. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

1 0

Re: [PATCH v8 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Nikolay Sivov (＠nsivov) 28 Nov '24

28 Nov '24

I suggest we close this, it's nothing but a cosmetic change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_89177

1 0

[PATCH v2 0/1] MR6438: winewayland: Delay setting user driver functions.
by Aida Jonikienė (＠DodoGTA) 28 Nov '24

28 Nov '24

This fixes segfaults and explorer.exe being stuck when this driver fails to load. -- v2: winewayland: Delay setting user driver functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/6438

2 5

Re: [PATCH v3 0/1] MR6908: win32u: Allow unsetting the user driver. - approved
by Alexandre Julliard (＠julliard) 28 Nov '24

28 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6908

1 0

Re: [PATCH v9 0/4] MR6680: msvcp140: Use current locale to convert path in _Fiopen. - approved
by Alexandre Julliard (＠julliard) 28 Nov '24

28 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

1 0

Re: [PATCH v2 0/1] MR3226: comctl32/edit: Scroll caret on Ctrl+A. - approved
by Alexandre Julliard (＠julliard) 28 Nov '24

28 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3226

1 0

Re: [PATCH v2 0/1] MR6899: vkd3d: Import upstream release 1.14. - approved
by Alexandre Julliard (＠julliard) 28 Nov '24

28 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6899

1 0

Re: [PATCH v2 0/1] MR6913: uxtheme: Check DrawThemeEdge() content rectangle pointer. - approved
by Alexandre Julliard (＠julliard) 28 Nov '24

28 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6913

1 0

2025

2024

2023

2022

wine-gitlab November 2024