November 2024 - wine-gitlab

Re: [PATCH v3 0/1] MR6894: d3dx9: Remove superfluous null check (Coverity) - approved
by Alexandre Julliard (＠julliard) 29 Nov '24

29 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6894

1 0

[PATCH 0/1] MR6930: d2d1/effect: Improve handling of blob properties.
by Nikolay Sivov (＠nsivov) 29 Nov '24

29 Nov '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6930

1 0

[PATCH 0/1] MR6929: kernelbase: Properly return 0 from EnumSystemFirmwareTable on error.
by Evan Tang (＠etang-cw) 29 Nov '24

29 Nov '24

6d1df55bf3b6051ad61e9c7cb7d63f13c1b9771f changed `NtQuerySystemInformation(SystemFirmwareTableInformation, ...)` to return 0 on error, which left `get_firmware_table` returning -16 This would be interpreted as a very large number by applications, breaking them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6929

3 2

[PATCH v2 0/1] MR6926: winex11: Don't tell win32 about offscreen window position.
by Rémi Bernon (＠rbernon) 29 Nov '24

29 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57472 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57474 -- v2: winex11: Don't update Win32 window position for offscreen windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6926

2 2

[PATCH 0/1] MR6928: mscoree: Update Wine Mono to 9.4.0.
by Esme Povirk (＠madewokherd) 29 Nov '24

29 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6928

3 2

[PATCH v5 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu (＠insn) 29 Nov '24

29 Nov '24

-- v5: mshtml: Don't expose some props from document prototype depending on mode. mshtml: Expose the right props from document fragments. mshtml: Use DocumentPrototype as the document's prototype for modes prior mshtml: Move HTMLDocument prototype props to the Document prototype. https://gitlab.winehq.org/wine/wine/-/merge_requests/6927

3 5

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Jacek Caban (＠jacek) 29 Nov '24

29 Nov '24

On Fri Nov 29 17:14:34 2024 +0000, Gabriel Ivăncescu wrote: > This seems to give me test failures about not finding "title" element, > only on wine. I assume we lack something to automatically put a title if > missing. What should I do? Ah, that's one of those parser differences with Gecko. Let's leave it as you did for now then. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89251

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu (＠insn) 29 Nov '24

29 Nov '24

On Fri Nov 29 17:00:58 2024 +0000, Jacek Caban wrote: > Let's try to avoid adding more strings here. You could change > `test_docfrag` to use `set_body_html` and then use the existing `doc_blank`/`doc_blank_ie9`. This seems to give me test failures about not finding "title" element, only on wine. I assume we lack something to automatically put a title if missing. What should I do? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89250

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Jacek Caban (＠jacek) 29 Nov '24

29 Nov '24

Jacek Caban (@jacek) commented about dlls/mshtml/tests/dom.c: > static const char emptydiv_str[] = > "<html><head><title>emptydiv test</title></head>" > "<body><div id=\"divid\"></div></body></html>"; > +static const char emptydiv_ie9_str[] = > + "<html><head><meta http-equiv=\"x-ua-compatible\" content=\"IE=9\"/><title>emptydiv test</title></head>" > + "<body><div id=\"divid\"></div></body></html>"; Let's try to avoid adding more strings here. You could change `test_docfrag` to use `set_body_html` and then use the existing `doc_blank`/`doc_blank_ie9`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89249

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Jacek Caban (＠jacek) 29 Nov '24

29 Nov '24

Jacek Caban (@jacek) commented about dlls/mshtml/mshtml_private.h: > > /* Used by objects that want to delay their compat mode initialization until actually needed */ > HTMLInnerWindow *(*get_script_global)(DispatchEx*); > + dispex_static_data_t *(*get_dispex_data)(DispatchEx*); Could we just extend `get_script_global` instead? Other than document objects, it's used only for windows anyways. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89248

1 0

2025

2024

2023

2022

wine-gitlab November 2024