November 2024 - wine-gitlab

Re: [PATCH v5 0/1] MR5924: Draft: mfmediaengine: Implement SVR.
by Nikolay Sivov (＠nsivov) 22 Nov '24

22 Nov '24

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c: > > static void free_media_engine(struct media_engine *engine) > { > + EnterCriticalSection(&engine->cs); This helper is called when refcount is already 0, nothing else should be using it at this point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5924#note_88684

1 0

Re: [PATCH v5 0/1] MR5924: Draft: mfmediaengine: Implement SVR.
by Nikolay Sivov (＠nsivov) 22 Nov '24

22 Nov '24

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/video_frame_sink.c: > + IMFMediaType *current_media_type; > + BOOL is_shut_down; > + IMFMediaEventQueue *event_queue; > + IMFMediaEventQueue *stream_event_queue; > + IMFPresentationClock *clock; > + IMFAsyncCallback *callback; > + float rate; > + enum sink_state state; > + unsigned int flags; > + IMFSample *sample[2]; > + IMFSample *presentation_sample; > + int sample_write_index; > + int sample_read_index; > + BOOL sample_request_pending; > + BOOL sample_presented; > + BOOL eos; These could be "bool", we use that in several modules already. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5924#note_88683

1 0

Re: [PATCH v5 0/1] MR5924: Draft: mfmediaengine: Implement SVR.
by Nikolay Sivov (＠nsivov) 22 Nov '24

22 Nov '24

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/video_frame_sink.c: > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFMediaEventGenerator_iface); > +} > + > +static struct video_frame_sink *impl_from_IMFStreamSink(IMFStreamSink *iface) > +{ > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFStreamSink_iface); > +} > + > +static struct video_frame_sink *impl_from_IMFMediaTypeHandler(IMFMediaTypeHandler *iface) > +{ > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFMediaTypeHandler_iface); > +} > + > +static void video_frame_sink_samples_release(struct video_frame_sink *sink) > +{ > + for (int i = 0; i < ARRAYSIZE(sink->sample); i++) ARRAY_SIZE is more common throughout the codebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5924#note_88682

1 0

Re: [PATCH v2 0/5] MR6879: dplayx: Connection caching. - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6879

1 0

Re: [PATCH v4 0/7] MR6846: winex11: Misc tweaks to the emulated display mode support. - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6846

1 0

Re: [PATCH v4 0/3] MR6882: secur32, urlmon, wininet: Fix some failing tests. - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6882

1 0

Re: [PATCH v3 0/2] MR6868: win32u: Fix a couple of raw monitor DPI issues. - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6868

1 0

Re: [PATCH v2 0/1] MR6880: gitlab: Wait for the fvwm process to start. - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6880

1 0

Re: [PATCH v3 0/1] MR6881: kernel32/tests: Check for the _SW_INVALID bit presence only. - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6881

1 0

Re: [PATCH v4 0/1] MR6523: wtsapi32: Handle WTSSessionInfo class in WTSQuerySessionInformationW(). - approved
by Alexandre Julliard (＠julliard) 22 Nov '24

22 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6523

1 0

2025

2024

2023

2022

wine-gitlab November 2024