Before this fix, the regex engine would run into an infinite loop and OOM when encountering a
quantifier allowing a zero amount of items in a REG_GLOB regex.
This fixes a freeze/crash in the Final Fantasy XIV Launcher during the registration process.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6840
On Mon Nov 18 14:44:04 2024 +0000, Vibhav Pant wrote:
> Well, from our conversation on IRC, I had merged them to reduce the MR
> from 10 commits to 7.
Let's keep it small for this MR. ~5 should be best. 8 is a bit too much. Having more patches in one MR makes it harder to review.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_87995
On Mon Nov 18 15:27:34 2024 +0000, Vibhav Pant wrote:
> `Iterable` has two separate implementations. One is derived from
> `MapView<HSTRING, IInspectable *>`, while the other is from the
> `IPropertySet`'s `Map<HSTRING, IInspectable *>` interface. Using
> `DEFINE_IINSPECTABLE` for both would create a conflict for the
> `impl_from_IIterable_IKeyValuePair_HSTRING_IInspectable` function.
Ok, I see.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6766#note_87994