This MR is a subset of MR 6715 [1]. It mainly contains fixes
and improvements in dbghelp handling of DEBUG directories in PE header.
Since 6715 may take some time to be finished (may take some more time
to have an approved solution), it seems preferable to land these
fixes/improvements in Wine before code freeze.
The changes in this MR:
- fixes loading dwarf info from PE files compiled by gcc/mingw with
--build-id option,
- several improvements for SymSrvGetFileIndexInfo (esp. native fails with
ERROR_BAD_EXE_FORMAT error code when there is no DEBUG directory;
yet, does it fill most of the information out of the PE image...
Note that images compiled with gcc/mingw compilation (dwarf debug info,
no buildid don't have DEBUG directories)
So mimic native's behavior, and fix some code paths accordingly,
- some fixes for .dbg handling (not much of an use today anyway).
[1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6715
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6818
Also removes ime.h from x11 keyboard driver.
In the that file imported from the mingw-w64 runtime seem also to be typos like `WM_IMEKEYDOWN` and `WM_IMEKEYUP` and is not used at all in wine, so theoretically it could be removed entirely...
Not too sure if there are any winelib considerations to be had here though.
--
v4: winex11: Include kbd.h instead of ime.h.
include: Add Japanese IME virtual key codes to kbd.h.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6819
On Fri Nov 15 14:47:18 2024 +0000, Akihiro Sagawa wrote:
> I manually tested the vertical features using a specially crafted
> TrueType file.
> The font file displays different circled numbers as vertical substitutes
> for Japanese punctuation marks (U+3001, U+3002) based on its lookup
> table.
> If the implementation chooses:
> - the first vert feature, i.e. no script/lang lookup, the app shows ①
> (U+2460's glyph).
> - the first script/lang tag (@@@@), it shows ② (U+2461's).
> - the 'DFLT' script, it shows ③ (U+2462's).
> - the 'kana' script, it shows ④ (U+2463's).
> What we can see is ① with plain gdi API.
> ![Capture](/uploads/ce5cba3c12e0debd2bdac94fd017d842/Capture.png)
> See [gsub.txt](/uploads/9d5ef683f937fc0b48f9f7e833fab930/gsub.txt) file
> in ttx format for details, please.
Thank you, this looks conclusive enough for me. Please rebase, but otherwise I think it's ready.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_87626
On Fri Nov 15 14:46:06 2024 +0000, Nikolay Sivov wrote:
> I think the remaining question here is if we want to remove script/lang
> lookup logic entirely, or instead prioritize. @sgwaki, any idea if it's
> possible to test that? Testing manually is fine. To be clear, test font
> should have at least two differing vert features, with second feature
> being testable with specific script/lang pair, if that is possible to
> achieve with plain gdi API at all.
I manually tested the vertical features using a specially crafted TrueType file.
The font file displays different circled numbers as vertical substitutes for Japanese punctuation marks (U+3001, U+3002) based on its lookup table.
If the implementation chooses:
- the first vert feature, i.e. no script/lang lookup, the app shows ① (U+2460's glyph).
- the first script/lang tag (@@@@), it shows ② (U+2461's).
- the 'DFLT' script, it shows ③ (U+2462's).
- the 'kana' script, it shows ④ (U+2463's).
What we can see is ① with plain gdi API.
![Capture](/uploads/ce5cba3c12e0debd2bdac94fd017d842/Capture.png)
See [gsub.txt](/uploads/9d5ef683f937fc0b48f9f7e833fab930/gsub.txt) file in ttx format for details, please.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_87621