On Sun Dec 22 18:39:49 2024 +0000, Nikolay Sivov wrote:
> What does it return for network drives?
> P.S. I see you closed !7050, please reuse same MR next time, that
> preserves comments and commits history.
Good question, this morning I shared a drive over smb from my Mac to my Windows 11 computer. I mounted the network drive and verified it worked. I re-ran the tests on Windows and drive_get_path was still outputting the drive letter and a colon "W:", even for the network drive. I am happy to add more specific tests with network drives if you think that would be beneficial?
Thanks for your feedback, I am very new to wine's code-base and really appreciate it. I apologize on the MR, thank you for the information. I had read your feedback that I needed to clean it (the last MR) and mistook that to mean make a new one, especially since my code was very different.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7060#note_91071
On Sun Dec 22 17:58:32 2024 +0000, Akihiro Sagawa wrote:
> From my point of view, SJIS is correct.
> Here is an example of SJIS locale usage written by [Red
> Hat](https://access.redhat.com/solutions/727043) and
> [HP-UX](https://web.archive.org/web/20061206132454/http://docs.hp.com/en/UXL…
> (see Appendix A).
> Historically, until around 2000, the Japanese UNIX environment mainly
> used an encoding different from Shift-JIS, called EUC-JP (Extended Unix
> Code for Japanese). Therefore, with the exception of HP-UX, SJIS has
> rarely been used in locale settings.
I'm not well versed in the topic, I wrote this patch, because on two of my systems (Mint and Artix), the charmap file is named SHIFT_JIS rather than SJIS.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7017#note_91069