December 2024 - wine-gitlab

Re: [PATCH v2 0/7] MR6911: ntdll: Add WaitCompletionPacket.
by Jinoh Kang (＠iamahuman) 14 Dec '24

14 Dec '24

On Sat Dec 14 13:05:29 2024 +0000, Jinoh Kang wrote: > > The problem is that there might be no threads that initiate any wait. > You're probably talking about GetQueuedCompletionStatus(). Sure, no > threads might be waiting on IOCP. By "initiate the wait" I mean the wait > on the (arbitrary) target object handle, not the IOCP. > NtAssociateWaitCompletionPacket() initiates an *asynchronous* wait on > the object handle. When the wait is done (the object is signaled), it > queues a completion to the associated I/O completion port. Note that this issue is currently masked by another omission in this MR: WaitCompletionPacket doesn't call obj->ops->satisfied(). Waiting on mutexes, semaphores, and auto-reset events have the side effect of acquiring or resetting their state. Your MR, in its current state, does _not_ let this side effect take place, rendering them useless. Maybe, in the particular case of React Native, it only uses WaitCompletionPacket on manual reset events or other objects with no-op satisfied()? FWIW I couldn't find any reference to NtAssociateWaitCompletionPacket in https://github.com/facebook/react-native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_90537

1 0

Re: [PATCH v2 0/7] MR6911: ntdll: Add WaitCompletionPacket.
by Jinoh Kang (＠iamahuman) 14 Dec '24

14 Dec '24

> The problem is that there might be no threads that initiate any wait. You're probably thinking about synchronous wait. By "initiate the wait" I mean the thread that called NtAssociateWaitCompletionPacket(). Not all waits are synchronous (like WaitForSingleObject). NtAssociateWaitCompletionPacket() initiates an *asynchronous* wait. When the wait is done (the object is signaled), it queues a completion to the associated I/O completion port. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_90531

1 0

[PATCH 0/1] MR7016: winex11.drv: Use NtUserReleaseDC() with hdc in X11DRV_vulkan_surface_presented().
by Paul Gofman (＠gofman) 14 Dec '24

14 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7016

3 2

Re: [PATCH v2 0/1] MR7012: winex11: Fix inconsistent coordinates when reparenting host window. - approved
by Alexandre Julliard (＠julliard) 13 Dec '24

13 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7012

1 0

Re: [PATCH v2 0/1] MR7011: server: Allow merging WM_MOUSEMOVE across internal messages. - approved
by Alexandre Julliard (＠julliard) 13 Dec '24

13 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7011

1 0

Re: [PATCH v2 0/8] MR7008: windowscodecs/tests: Use test context in a few metadata tests. - approved
by Alexandre Julliard (＠julliard) 13 Dec '24

13 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7008

1 0

Re: [PATCH v4 0/1] MR6994: explorer: Avoid hiding the taskbar if it's enabled. - approved
by Alexandre Julliard (＠julliard) 13 Dec '24

13 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6994

1 0

[PATCH v45 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 13 Dec '24

13 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v45: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 4

[PATCH v2 0/2] MR5009: ntoskrnl.exe: Support ImagePaths just starting with System32.
by Bernhard Übelacker (＠bernhardu) 13 Dec '24

13 Dec '24

https://bugs.winehq.org/show_bug.cgi?id=51998 The first patch should make no functional change, just move the block out to a helper function. I assume changing to L"" literals is expected? The second patch handles ImagePaths starting with `System32` similar like it is already done for `\\SystemRoot\\` and adds the windows directory in front of it. -- v2: ntoskrnl.exe: Support ImagePaths just starting with System32. ntoskrnl.exe: Add helper to create absolute ImagePath. https://gitlab.winehq.org/wine/wine/-/merge_requests/5009

3 5

[PATCH v16 0/3] MR4915: d3d9: Implement Direct3DCreate9On12().
by Mohamad Al-Jaf (＠maljaf) 13 Dec '24

13 Dec '24

Needed by Orbiter Space Flight Simulator and Train Simulator Classic. -- v16: d3d9/tests: Add Direct3DCreate9On12() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4915

5 7

2025

2024

2023

2022

wine-gitlab December 2024