December 2024 - wine-gitlab

[PATCH 0/2] MR6955: include, ntdll: Use %fs/%gs prefixes instead of a separate .byte 0x64/.byte 0x65.
by Brendan Shanks (＠bshanks) 04 Dec '24

04 Dec '24

Part of this patch was [submitted 3 years ago](https://list.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.org… by Keno Fischer, but was not merged. The separate `.byte` causes `gas` to [emit incorrect DWARF line info](https://sourceware.org/bugzilla/show_bug.cgi?id=28699), which caused a [crash in rr](https://github.com/rr-debugger/rr/issues/3009). Using `%fs`/`%gs` is also clearer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6955

2 2

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 04 Dec '24

04 Dec '24

On Mon Dec 2 10:29:56 2024 +0000, eric pouech wrote: > question: do you need both calls to test_NtQueryDirectoryFile_mask to > invalidate a platform? Given that the key behaviour we're testing involves the reuse of a handle, we need at least two calls. I could change it so we only verify the results of the second call, and not the first, if that would be preferable? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89654

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 04 Dec '24

04 Dec '24

On Mon Dec 2 10:29:56 2024 +0000, eric pouech wrote: > tracing GetLastError() is pointless here (you're testing ntdll APIs, > while GetLastError() reflects kernel32/kernelbase API results) Excellent point, I'll report the `status` instead -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89652

1 0

Re: [PATCH v2 0/5] MR6953: quartz: Improve dsoundrender style. - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6953

1 0

Re: [PATCH v2 0/3] MR6915: Correctly return failures for dmo_wrapper_sink_Receive(). - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6915

1 0

Re: [PATCH v3 0/8] MR6951: msvcrt: Prepare more functions to handle utf-8 encoded file names. - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6951

1 0

Re: [PATCH v2 0/1] MR6949: gdiplus: Cast enums to unsigned type when validating its value. - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6949

1 0

Re: [PATCH v5 0/2] MR6948: Vulkan object rework hotfixes. - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6948

1 0

Re: [PATCH v8 0/2] MR3563: server: Symlink CurrentControlSet to ControlSet001 - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3563

1 0

Re: [PATCH v2 0/1] MR6941: winevulkan: Update to VK spec version 1.4.303. - approved
by Alexandre Julliard (＠julliard) 03 Dec '24

03 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6941

1 0

2025

2024

2023

2022

wine-gitlab December 2024