December 2024 - wine-gitlab

[PATCH v28 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v28: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v14 0/3] MR6737: comctl32/toolbar: forward WM_NOTIFY CBEN_ENDEDITW
by Alanas Tebuev (＠BZZZZ) 02 Dec '24

02 Dec '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v14: comctl32/toolbar: Forward WM_NOTIFY CBEN_ENDEDITW. comctl32: Move WM_NOTIFY unicode to ansi conversion code from pager.c to commctrl.c. comctl32/tests: Test WM_NOTIFY CBEN_ENDEDITW conversion and forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

4 6

[PATCH v2 0/9] MR6931: win32u: Move surface and swapchain wrappers from winevulkan.
by Rémi Bernon (＠rbernon) 02 Dec '24

02 Dec '24

-- v2: win32u: Move surface and swapchain wrappers from winevulkan. win32u: Keep track of redirected host vulkan functions. winevulkan: Pass wrapper structs to win32u_vkGet(Device|Instance)ProcAddr. winevulkan: Use the vulkan object as the wrapper tree node. winevulkan: Get rid of unnecessary *to_handle helpers. winevulkan: Avoid changing client command buffer pointer. winevulkan: Fix incorrect client queue pointers. winevulkan: Introduce a new vulkan_object_init helper. winevulkan: Use the result to decide if creation failed. https://gitlab.winehq.org/wine/wine/-/merge_requests/6931

3 13

Re: [PATCH v2 0/7] MR6911: ntdll: Add WaitCompletionPacket.
by Zhiyi Zhang (＠zhiyi) 02 Dec '24

02 Dec '24

On Sun Dec 1 21:56:35 2024 +0000, Jinoh Kang wrote: > I'd advise you to test WaitCompletionPacket againat waitable objects > that use `get_wait_queue_thread()`, including keyed events, mutexes, and > message queue objects (not exposed via Win32 API, only at win32k level). Thanks for the review. The problem is that there might be no threads that initiate any wait. Anyway, I will add more tests and get back to you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_89419

1 0

[PATCH v27 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v27: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

2 2

[PATCH v2 0/3] MR6939: include: Enable format attributes for debug traces in Clang MSVC mode.
by Jacek Caban (＠jacek) 02 Dec '24

02 Dec '24

-- v2: include: Enable format attributes for debug traces in Clang MSVC mode. mmdevapi/tests: Use %u format for unsigned int arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/6939

2 4

[PATCH v26 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 02 Dec '24

02 Dec '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v26: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 5

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

I mostly commented the first patch for the tests... we need I'm afraid more tests to discriminate whether the scan mask is bound to directory handle or to the directory itself reading MSDN doc [1] suggests that it's likely the former; but I never trust MSDN doc, hence the need to more tests, esp with two handles opened to the same directory and test the mixing of calls if it's the case, then it means that tweaking the fd cache is wrong (as you in your second patch), and we likely need another layer for storing the mask [1] https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-nti… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89400

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c: > + InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL); > + > + /* Open a handle for our test directory */ > + status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ, > + FILE_SYNCHRONOUS_IO_NONALERT | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE); > + ok( status == STATUS_SUCCESS, "failed to open dir '%s', ret 0x%lx, error %ld\n", testdir, status, GetLastError() ); > + if (status != STATUS_SUCCESS) > + { > + skip("can't test if we can't open the directory\n"); > + goto done; > + } > + > + /* Verify that updated windows 8 and higher behaviour is supported */ > + if (!winetest_platform_is_wine && !test_NtQueryDirectoryFile_mask(dirh, TRUE, atestfile, TRUE, TRUE)) > + run_updated_tests = FALSE; > + if (!winetest_platform_is_wine && !test_NtQueryDirectoryFile_mask(dirh, TRUE, notatestfile, FALSE, TRUE)) question: do you need both calls to test_NtQueryDirectoryFile_mask to invalidate a platform? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89399

1 0

Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by eric pouech (＠epo) 02 Dec '24

02 Dec '24

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c: > + /* Clean up from prior aborted run, if any, then set up test files */ > + ok( GetTempPathA(MAX_PATH, testdir), "couldn't get temp dir\n" ); > + strcat(testdir, "mask.tmp"); > + tear_down_mask_test(testdir); > + set_up_mask_test(testdir); > + > + pRtlMultiByteToUnicodeN(testdir_w, sizeof(testdir_w), NULL, testdir, strlen(testdir) + 1); > + if (!pRtlDosPathNameToNtPathName_U(testdir_w, &ntdirname, NULL, NULL)) > + { > + ok( 0, "RtlDosPathNametoNtPathName_U failed\n" ); > + goto done; > + } > + InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL); > + > + /* Open a handle for our test directory */ > + status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ, indentation issue (mix of tab & spaces?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89398

1 0

2025

2024

2023

2022

wine-gitlab December 2024