December 2024 - wine-gitlab

Re: [PATCH v6 0/2] MR7060: scrrun/tests: Add drive_get_path test
by Quinn Rafferty (＠ramleejo) 22 Dec '24

22 Dec '24

On Sun Dec 22 18:39:49 2024 +0000, Nikolay Sivov wrote: > What does it return for network drives? > P.S. I see you closed !7050, please reuse same MR next time, that > preserves comments and commits history. Good question, this morning I shared a drive over smb from my Mac to my Windows 11 computer. I mounted the network drive and verified it worked. I re-ran the tests on Windows and drive_get_path was still outputting the drive letter and a colon "W:", even for the network drive. I am happy to add more specific tests with network drives if you think that would be beneficial? Thanks for your feedback, I am very new to wine's code-base and really appreciate it. I apologize on the MR, thank you for the information. I had read your feedback that I needed to clean it (the last MR) and mistook that to mean make a new one, especially since my code was very different. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7060#note_91071

1 0

Re: [PATCH v2 0/1] MR7017: ntdll: Set the correct character map name for Shift JIS
by Zsolt Vadász (＠zsoltiv) 22 Dec '24

22 Dec '24

On Sun Dec 22 17:58:32 2024 +0000, Akihiro Sagawa wrote: > From my point of view, SJIS is correct. > Here is an example of SJIS locale usage written by [Red > Hat](https://access.redhat.com/solutions/727043) and > [HP-UX](https://web.archive.org/web/20061206132454/http://docs.hp.com/en/UXL… > (see Appendix A). > Historically, until around 2000, the Japanese UNIX environment mainly > used an encoding different from Shift-JIS, called EUC-JP (Extended Unix > Code for Japanese). Therefore, with the exception of HP-UX, SJIS has > rarely been used in locale settings. I'm not well versed in the topic, I wrote this patch, because on two of my systems (Mint and Artix), the charmap file is named SHIFT_JIS rather than SJIS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7017#note_91069

1 0

[PATCH v3 0/6] MR6866: Draft: ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code.
by Brendan Shanks (＠bshanks) 22 Dec '24

22 Dec '24

x86_64 Windows and macOS both use `%gs` to access thread-specific data (Windows TEB, macOS TSD). To date, Wine has worked around this conflict by filling the most important TEB fields (`0x30`/`Self`, `0x58`/`ThreadLocalStorage`) in the macOS TSD structure (Apple reserved the fields for our use). This was sufficient for most Windows apps. CrossOver's Wine had an additional hack to handle `0x60`/`ProcessEnvironmentBlock`, and binary patches for certain CEF binaries which directly accessed `0x8`/`StackBase`. Additionally, Apple's libd3dshared could activate a special mode in Rosetta 2 where code executing in certain regions would use the Windows TEB when accessing `%gs`. Now that the PE separation is complete, GSBASE can be swapped when entering/exiting PE code. This is done in the syscall dispatcher, unix-call dispatcher, and for user-mode callbacks. GSBASE also needs to be set to the macOS TSD when entering signal handlers (in `init_handler()`), and then restored to the Windows TEB when exiting (in `leave_handler()`). There is a special-case needed in `usr1_handler`: when inside a syscall (on the kernel stack), GSBASE may need to be reset to either the TEB or the TSD. The only way to tell is to determine what GSBASE was set to on entry to the signal handler. --- macOS does not have a public API for setting GSBASE, but the private `_thread_set_tsd_base()` works and was added in macOS 10.12. `_thread_set_tsd_base()` is a small thunk that sets `%esi`, `%eax`, and does the `syscall`: https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57…. The syscall instruction itself clobbers `%rcx` and `%r11`. I've tried to save as few registers as possible when calling `_thread_set_tsd_base()`, but there may be room for improvement there. --- I've tested this successfully on macOS 15 (Apple Silicon and Intel) with several apps and games, including the `cefclient.exe` CEF sample. I still need to test this patch on macOS 10.13, and I'd also like to do some performance testing. --- I also tested an alternate implementation strategy for this which took advantage of the expanded "full" thread state which is passed to signal handlers when a process has set a user LDT. The full thread state includes GSBASE, so GSBASE is set back to whatever is in the sigcontext on return (like every other field in the context). This would avoid needing to explicitly reset GSBASE in `leave_handler()`, and avoid the special-case in `usr1_handler()`. This strategy was simpler, but I'm not using it for 2 reasons: - the "full" thread state is only available starting with macOS 10.15, and we still support 10.13. - more crucially, Rosetta 2 doesn't seem to correctly implement the GS.base field of the full thread state. It's set to 0 on entry, and isn't read on exit. -- v3: ntdll: Remove x86_64 Mac-specific TEB access workarounds that are no longer needed. ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code. ntdll: Ensure init_handler runs in signal handlers before any compiler-generated memset calls. ntdll: Remove ugly fallback method for getting a thread's GSBASE on macOS. ntdll: Leave kernel stack before accessing %gs in x86_64 syscall dispatcher. ntdll: Do %gs accesses before switching to kernel stack in x86_64 syscall dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/6866

4 8

[PATCH v3 0/2] MR7064: Draft: ntdll: Check for invalid %gs value in 32-bit code on WoW64.
by William Horvath (＠whrvth) 22 Dec '24

22 Dec '24

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated in 32-bit code on "new-style" WoW64. [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) is a simple reproduction of the crash, courtesy of Fabian Maurer from the Bugzilla comments. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- v3: ntdll: Check for invalid %gs value in 32-bit code on WoW64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

3 5

Re: [PATCH v6 0/2] MR7060: scrrun/tests: Add drive_get_path test
by Nikolay Sivov (＠nsivov) 22 Dec '24

22 Dec '24

What does it return for network drives? P.S. I see you closed !7050, please reuse same MR next time, that preserves comments and commits history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7060#note_91053

1 0

[PATCH 0/1] MR7065: comctl32/tests: Use sufficient user data buffer in the Tab tests (ASan)
by Nikolay Sivov (＠nsivov) 22 Dec '24

22 Dec '24

The issue here is that TCITEM is not enough to hold lparam over sizeof(LPARAM). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7065

2 2

[PATCH v2 0/2] MR7064: Draft: ntdll: Check for invalid %gs value in 32-bit code on WoW64.
by William Horvath (＠whrvth) 22 Dec '24

22 Dec '24

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated in 32-bit code on "new-style" WoW64. [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) is a simple reproduction of the crash, courtesy of Fabian Maurer from the Bugzilla comments. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- v2: ntdll: Check for invalid %gs value in 32-bit code on WoW64. ntdll: Allow get_current_teb assembly to be used on all platforms. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

2 3

[PATCH 0/1] MR7064: ntdll: Check for invalid %gs value in 32-bit code on WoW64.
by William Horvath (＠whrvth) 22 Dec '24

22 Dec '24

Adapted from check_invalid_gs in [signal_i386.c](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad34a…. This prevents crashing when the %gs register is manipulated in 32-bit code on "new-style" WoW64. [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) is a simple reproduction of the crash, courtesy of Fabian Maurer from the Bugzilla comments. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

3 3

[PATCH 0/11] MR7063: win32u: More fixes for arcs.
by Elizabeth Figura (＠zfigura) 22 Dec '24

22 Dec '24

This time including some regression tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7063

3 12

[PATCH 0/1] MR7062: dwrite: Avoid stack-buffer-overflow in arabic_setup_masks.
by Nikolay Sivov (＠nsivov) 22 Dec '24

22 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7062

2 2

2025

2024

2023

2022

wine-gitlab December 2024