February 2024 - wine-gitlab

[PATCH 0/1] MR5165: wined3d: Slightly adjust an ERR in shader_spirv_compile_shader().
by Henri Verbeet (＠hverbeet) 05 Mar '24

05 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5165

4 3

[PATCH v2 0/6] MR5171: wined3d/nvrc: Move state application to nvrc_apply_draw_state().
by Zebediah Figura (＠zfigura) 05 Mar '24

05 Mar '24

-- v2: wined3d/nvrc: Remove now redundant WINED3D_TSS_RESULT_ARG handlers. wined3d/nvrc: Move alpha op application to nvrc_apply_draw_state(). wined3d/nvrc: Remove now redundant STATE_SAMPLER handlers. wined3d/nvrc: Move color ops from nvrc_colorop() to nvrc_apply_draw_state(). wined3d/nvrc: Move FFP bumpenv constant loading to nvrc_apply_draw_state(). wined3d/nvrc: Move TEXTUREFACTOR constant loading to nvrc_apply_draw_state(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5171

3 7

[PATCH v4 0/1] MR673: tests/shader-runner: Add sampler comparison tests.
by Conor McCarthy (＠cmccarthy) 05 Mar '24

05 Mar '24

-- v4: tests/shader-runner: Add sampler comparison tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/673

3 2

[PATCH v2 0/6] MR5193: mouhid, win32u: Send and receive WM_POINTER messages.
by Rémi Bernon (＠rbernon) 05 Mar '24

05 Mar '24

-- v2: win32u: Add support for sending and receiving WM_POINTER* messages. server: Add support for sending and receiving WM_POINTER* messages. mouhid.sys: Send WM_POINTER* messages on contact updates. dinput/tests: Test the WM_POINTER* message parameter values. win32u: Use a custom struct hid_input for NtUserSendHardwareInput. https://gitlab.winehq.org/wine/wine/-/merge_requests/5193

4 11

[PATCH v2 0/1] MR5083: server: Try to retrieve the unix name on handles created from file descriptors.
by Gabriel Ivăncescu (＠insn) 04 Mar '24

04 Mar '24

Useful with unix integration of redirected standard handles. Simple testcase: ```c #include <windows.h> #include <stdio.h> int main(int argc, char **argv) { char buf[4096] = {0}; FILE_NAME_INFO *name_info = (FILE_NAME_INFO*)buf; if (!GetFileInformationByHandleEx(GetStdHandle(STD_OUTPUT_HANDLE), FileNameInfo, name_info, sizeof(buf))) { fprintf(stderr, "GetFileInformationByHandleEx failed %08lx\n", GetLastError()); return 1; } WriteFile(GetStdHandle(STD_ERROR_HANDLE), name_info->FileName, name_info->FileNameLength, NULL, NULL); return 0; } ``` On Windows: ``` test.exe > C:\Temp\test.txt ``` Output: ``` \Temp\test.txt ``` On wine: ``` wine test.exe > /tmp/wine/testprefix/drive_c/Temp/test.txt ``` Upstream output: ``` GetFileInformationByHandleEx failed 00000006 ``` With this MR: ``` \Temp\test.txt ``` -- v2: server: Try to retrieve the unix name on handles created from file https://gitlab.winehq.org/wine/wine/-/merge_requests/5083

3 5

[PATCH v2 0/1] MR5146: d3dcompiler: Enable semantic naming mapping in compatibility mode.
by Nikolay Sivov (＠nsivov) 04 Mar '24

04 Mar '24

This was implemented in vkd3d 1.10. Another known feature that has to be enabled with compatibility flag is d3d9 style sampling functions. We currently don't do that, making them supported unconditionally. -- v2: d3dcompiler: Enable semantic names mapping in compatibility mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5146

3 2

[PATCH 0/2] MR5158: rtworkq: Avoid closing a thread pool object while its callbacks are running.
by Zhiyi Zhang (＠zhiyi) 04 Mar '24

04 Mar '24

Patch 2 fixes a race condition in theory. I haven't found it affecting any real-world applications. These two bugs are caused by race conditions. I don't think adding tests could demonstrate them reliably. This MR can probably fix the race condition mentioned at https://gitlab.winehq.org/wine/wine/-/merge_requests/4243 patch 3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5158

3 4

[PATCH v2 0/7] MR5174: win32u: Simplify sysparams using ascii strings for registry operations when possible.
by Rémi Bernon (＠rbernon) 04 Mar '24

04 Mar '24

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5137 -- v2: win32u: Introduce and use new reg_(open|create)_ascii_key helpers. win32u: Use set_reg_ascii_value whenever possible. win32u: Remove unnecessary class_guidW double check. win32u: Use REG_SZ instead of REG_BINARY for some adapter keys. win32u: Remove unused wine_devpropkey_monitor_adapternameW property. win32u: Simplify adapter key path creation from gpu_guid. win32u: Use char array for the device manager context gpuid. https://gitlab.winehq.org/wine/wine/-/merge_requests/5174

2 8

[PATCH 0/1] MR667: win32u: Ignore SetWindowPos() if it is trying to change topmost state for child window.
by Paul Gofman (＠gofman) 03 Mar '24

03 Mar '24

I think the behaviour of SetWindowPos() in this case is partially explained by the fact that topmost state is not strictly applicable to child windows and so Windows denies such requests. Child window can still end up with WS_EX_TOPMOST style if it was set at window creation (doesn't work this way in Wine now) or, e. g., like in the test added in the patch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=20190 Also fixes game load dialog in Indiana Jones and the Infernal Machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/667

6 6

[PATCH v3 0/1] MR4206: Draft: gdiplus: Check bounding box in GdipIsVisibleRegionPoint.
by Esme Povirk (＠madewokherd) 02 Mar '24

02 Mar '24

I don't think this should be committed so late in the release cycle, but the work others have been doing with point checking functions inspired me to move on this, and I wanted to let folks know what I'm thinking about and get some feedback. Consider it a proof of concept for now. The problem: GdipGetRegionHRgn is expensive. Regardless of how much of the region we actually care about, we must rasterize the entire plane of that region. Currently, we rely on gdi32 to do this, which doesn't provide us with any way to ask for a smaller area. This has been a real problem for applications that work with very large, non-rectangular regions or paths. So it seems to me, the solution will involve writing two functions, one of which is in this MR: a bounding-box calculation for regions, and rasterization. Since the result of rasterization will be short-lived, I think it should always be an array of bytes (which are effectively a bitmap but don't require bitwise operations to work with). The rasterization should be limited to a specific integer rectangle, which in the case of GdipIsVisibleRegionPoint can be 1x1 pixel. We should then be able to eliminate all internal uses of GdipGetRegionHRgn, except when we have to return an HRGN to the application. This would also be useful for implementing anti-aliasing, as we could keep the memory usage down by only rasterizing the part we need for each scanline at a time. My current concerns about what I've written so far: * Although it shouldn't change the behavior, I doubt it's adequately tested, even including the Mono tests. I'd like to ideally test every combine mode in a variety of cases. * This is too clever for its own good. Unfortunately, with the complexity of handling so many combine modes as well as infinities for each region being combined, I think the only available choices are "too clever for its own good" and "20 different special cases that need to be considered manually". Still, I want to make this as simple and easy to follow as possible, within its requirements. -- v3: gdiplus: Check bounding box in GdipIsVisibleRegionPoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/4206

6 9

2025

2024

2023

2022

wine-gitlab February 2024