On Wed Nov 22 18:02:56 2023 +0000, eric pouech wrote:
> my point is more about the way to implement the fix rather if the
> propose fix passes the tests
> cmd as of today is barely maintanable because of small adjustements here
> and there, added over the years
> your proposal is such a small adjustment by changing behavior of some
> helper functions, depending on context, whereas IMO the cause of the
> issue lies elsewhere
I can appreciate the fact that Wine's cmd.exe implementation is kind of ugly. Nonetheless, in my opinion it's not reasonable to require a near-total rewrite of cmd.exe in order to fix this bug. `IF` is very special in cmd, and would still have to be treated specially even if cmd.exe were completely rewritten. The correct order of operations is to expand % variables, then parse the operands, then expand ! variables. Whether we have functions like handleExpansion, evaluate_if_condition, and do_delayed_expansion for those steps or whether we have a tokenizer that does it all, there has to be code to define the order, and that code would be similar in either case.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4418#note_61991
--
v5: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions.
vkd3d-shader/dxil: Move the resource kind helper functions up.
vkd3d-shader/spirv: Introduce a sample info flag value for a scalar uint dst parameter.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629
--
v5: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore.
vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store().
vkd3d-shader/dxil: Implement DX intrinsic BufferStore.
tests/shader-runner: Add a test for a signed int structured buffer UAV.
tests/shader-runner: Add a test for a signed int typed buffer UAV.
tests/shader-runner: Support structured buffer UAVs.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642
This is a relatively small step towards cleaning up the dumping ground that Wine's winternl.h has become.
--
v2: include: Move CPTABLEINFO and NLSTABLEINFO from winternl.h to ntnls.h.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5102
This first MR create an internal structured representation of the CFG and computes the domination relationship. Over a few other MRs I will implement an algorithm inspired to [this article](https://medium.com/leaningtech/solving-the-structured-control-flow… to compute a better structure than the one we already have, but for the moment the computed data is immediately wasted.
--
v2: vkd3d-shader/ir: Dump the domination relationship.
vkd3d-shader/ir: Compute the domination relationship.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/656
On Mon Feb 19 22:15:56 2024 +0000, Henri Verbeet wrote:
> How about the
> [attached](/uploads/d104ebd37a462b4fd375640b9e97eb93/patches.mbox.xz)
> series? I turns out that it's a bit awkward to make the
> "rasteriser_ordered" flag specific to UAVs due to the way
> "resource_format" is currently used, but making it a resource flag seems
> close enough to me. The series has a minor conflict with 569.
I guess `hlsl_types_are_equal()` should be updated too?
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_61968