copy implementation of CopyFileExW into CopyFile2,
then implement CopyFileExW in terms of CopyFile2
should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2.
- followed [the Wiki](https://wiki.winehq.org/Developer_Hints#Implementing_new_API_calls) for adding a new API call
- run `file.c` tests and they seem to pass
I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended.
I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up.
--
v7: create CopyFile2_impl and CopyFile2
https://gitlab.winehq.org/wine/wine/-/merge_requests/5020
Strings are opaque objects in HLSL. This implements recognizing string
literals and the `string` type.
This should fix the bug marked below but I'm not sure how to get my
hands on a copy of Lego Star Wars Saga to test it properly.
This is a super-duper draft MR; I'm certain there's problems with it.
I do at least have a passing test, though.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50382
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/305
On Mon Jan 15 22:01:58 2024 +0000, Giovanni Mascellani wrote:
> This is not wrong either, but we have a better tool for that, which is
> `vkd3d_string_buffer_printf()` (and companions).
> Also, notice that the `if` continuation line should be indented 8
> spaces, not 4.
What would make `vkd3d_string_buffer_printf` better? It looks like `hlsl_sprintf_alloc` just forwards to that inside and I don't see what I would be writing that would be better.
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60821