March 2024 - wine-gitlab

[PATCH v3 0/1] MR4206: Draft: gdiplus: Check bounding box in GdipIsVisibleRegionPoint.
by Esme Povirk (＠madewokherd) 02 Mar '24

02 Mar '24

I don't think this should be committed so late in the release cycle, but the work others have been doing with point checking functions inspired me to move on this, and I wanted to let folks know what I'm thinking about and get some feedback. Consider it a proof of concept for now. The problem: GdipGetRegionHRgn is expensive. Regardless of how much of the region we actually care about, we must rasterize the entire plane of that region. Currently, we rely on gdi32 to do this, which doesn't provide us with any way to ask for a smaller area. This has been a real problem for applications that work with very large, non-rectangular regions or paths. So it seems to me, the solution will involve writing two functions, one of which is in this MR: a bounding-box calculation for regions, and rasterization. Since the result of rasterization will be short-lived, I think it should always be an array of bytes (which are effectively a bitmap but don't require bitwise operations to work with). The rasterization should be limited to a specific integer rectangle, which in the case of GdipIsVisibleRegionPoint can be 1x1 pixel. We should then be able to eliminate all internal uses of GdipGetRegionHRgn, except when we have to return an HRGN to the application. This would also be useful for implementing anti-aliasing, as we could keep the memory usage down by only rasterizing the part we need for each scanline at a time. My current concerns about what I've written so far: * Although it shouldn't change the behavior, I doubt it's adequately tested, even including the Mono tests. I'd like to ideally test every combine mode in a variety of cases. * This is too clever for its own good. Unfortunately, with the complexity of handling so many combine modes as well as infinities for each region being combined, I think the only available choices are "too clever for its own good" and "20 different special cases that need to be considered manually". Still, I want to make this as simple and easy to follow as possible, within its requirements. -- v3: gdiplus: Check bounding box in GdipIsVisibleRegionPoint. https://gitlab.winehq.org/wine/wine/-/merge_requests/4206

6 9

[PATCH v21 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 02 Mar '24

02 Mar '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v21: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. win32u: Add a weak reference count to the shared session. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 22

Re: [PATCH v4 0/2] MR5186: win32u: fix NtGdiExtCreateRegion implementation
by Jinoh Kang (＠iamahuman) 01 Mar '24

01 Mar '24

Jinoh Kang (@iamahuman) commented about dlls/gdi32/tests/clipping.c: > /* Cannot be smaller than sizeof(RGNDATAHEADER) */ > SetLastError(0xdeadbeef); > hrgn = ExtCreateRegion(NULL, sizeof(RGNDATAHEADER) - 1, &rgn.data); > - todo_wine > ok(!hrgn, "ExtCreateRegion should fail\n"); > - todo_wine > + /* From Windows 7 returns ERROR_INVALID_PARAMETER error */ > ok(GetLastError() == ERROR_INVALID_PARAMETER || > - broken(GetLastError() == 0xdeadbeef), "0xdeadbeef, got %lu\n", GetLastError()); > + GetLastError() == 0xdeadbeef, "ERROR_INVALID_PARAMETER (win7+) or 0xdeadbeef, got %lu\n", GetLastError()); You should keep the broken() if 0xdeadbeef is not the latest Windows behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5186#note_63259

1 0

[PATCH v7 0/2] MR5178: winewayland.drv: set wayland app-id from the process name
by llyyr (＠llyyr) 01 Mar '24

01 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56000 -- v7: winewayland.drv: Implement SetWindowText. winewayland.drv: Set wayland app-id from the process name. https://gitlab.winehq.org/wine/wine/-/merge_requests/5178

3 5

Re: [PATCH v2 0/2] MR5207: Fixes for IME input on older macOS versions/hardware - approved
by Alexandre Julliard (＠julliard) 01 Mar '24

01 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5207

1 0

Re: [PATCH v2 0/2] MR5206: gdiplus: Implement font linking in GdipAddPathString. - approved
by Alexandre Julliard (＠julliard) 01 Mar '24

01 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5206

1 0

Re: [PATCH v2 0/5] MR5198: Explicitly request debug info in critical sections. - approved
by Alexandre Julliard (＠julliard) 01 Mar '24

01 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5198

1 0

Re: [PATCH v2 0/1] MR5205: wine.inf: Register the New menu as a directory background context menu handler. - approved
by Alexandre Julliard (＠julliard) 01 Mar '24

01 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5205

1 0

Re: [PATCH v3 0/3] MR5190: dmime: MIDI tempotrack - approved
by Alexandre Julliard (＠julliard) 01 Mar '24

01 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5190

1 0

Re: [PATCH v2 0/1] MR5164: wined3d: Pass "shader->function" as source to vkd3d_shader_scan() in shader_spirv_scan_shader(). - approved
by Alexandre Julliard (＠julliard) 01 Mar '24

01 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5164

1 0

2025

2024

2023

2022

wine-gitlab March 2024