March 2024 - wine-gitlab

[PATCH 0/1] MR5298: wined3d: Do not check the input signature element count for sm4+ shaders in shader_spirv_compile_arguments_init().
by Henri Verbeet (＠hverbeet) 15 Mar '24

15 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5298

5 4

[PATCH 0/3] MR5317: win32u: Fix a possible condition that makes EnumDisplayMonitors() not reporting any monitors.
by Zhiyi Zhang (＠zhiyi) 15 Mar '24

15 Mar '24

When there are two monitors and they are mirrored, both of them are considered primary. When the first primary monitor happens to be a clone, EnumDisplayMonitors() ends up not reporting any monitors because should_enumerate_monitor() returns FALSE and we break out the loop to enumerate primary monitors after that. This is a regression from b59619d and my review comments. My indent was to break out of the loop after finding the *master* primary monitor, not cloned primary monitors, to avoid unnecessary iterations. However, the primary monitor count is small and it's cleaner this way so let's break when should_enumerate_monitor() returns TRUE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5317

3 4

[PATCH 0/1] MR5305: ddraw: Release only valid texture parents on ddraw_texture_init failure.
by Andrew Nguyen (＠arethusa) 15 Mar '24

15 Mar '24

When ddraw_texture_init needs to clean up on failure, it will call the wined3d_texture_get_sub_resource_parent function on draw_texture in order to retrieve its parent for a IDirectDrawSurface release call. However, if draw_texture is NULL, then the function call will crash due to a null pointer dereference. Therefore, on failure cleanup, the release operation on the texture parent should only be performed if draw_texture is not NULL. This fixes a crash in the Virtual Insanity game demo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5305

5 5

[PATCH v7 0/7] MR631: Draft: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v7: tests: Trace more info on buffer creation failure. vkd3d: Support aliased tile binding if available. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for textures. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for buffers. vkd3d: Pre-bind sparse texture mip tails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 7

[PATCH v3 0/5] MR718: vkd3d-shader/dxil: Implement miscellaneous arithmetic DX intrinsics.
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v3: vkd3d-shader/dxil: Implement DX intrinsic Saturate. vkd3d-shader/dxil: Implement DX intrinsic FAbs. vkd3d-shader/dxil: Implement DX intrinsics FMa, FMad, IMad and UMad. vkd3d-shader/spirv: Use dst register data type in spirv_compiler_emit_imad(). tests/hlsl: Add tests for mad() and fma(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/718

2 5

[PATCH 0/5] MR722: Draft: vkd3d-shader/ir: Synthesize selection constructs from conditional jumps.
by Giovanni Mascellani (＠giomasce) 14 Mar '24

14 Mar '24

This applies on top of !711, the last three commits belong here. This MR and the following ones will introduce a number of optimization passes on the structured representation of the shader, with the goal of fixing the idiosyncrasies of the code generated by the new structurizer. The general pattern is that we want to recognize when the combination of loops and jumps can be rather written with selection constructs. Ideally that should bring to removing all the synthesized loop intervals, but that cannot be guaranteed in general. We still want to do remove all the loops we can, first to make the generated code easier to read and to recompile, and second because having fewer loops also means that more multilevel jumps become ordinary single level jumps, which do not require overhead to be represented in SPIR-V. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/722

2 5

Re: [PATCH v2 0/4] MR719: [2/3] vkd3d-shader/ir: Pass a struct vsir_program to vkd3d_shader_normalise(). - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/719

1 0

Re: [PATCH v2 0/2] MR720: vkd3d-shader/glsl: Generate comments for unhandled instructions. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/720

1 0

Re: [PATCH v4 0/6] MR706: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 3. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/706

1 0

Re: [PATCH v6 0/3] MR704: vkd3d-shader/ir: Introduce a better CFG structurizer, part 5. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/704

1 0

2025

2024

2023

2022

wine-gitlab March 2024