April 2024 - wine-gitlab

[PATCH 0/2] MR5473: wow64: Mind generic xstate in a couple of missed places.
by Paul Gofman (＠gofman) 08 Apr '24

08 Apr '24

Fixes some wow64 mode regressions introduced by commit 29c73ee17335b30f3f49c8b3562742c6a35b482c ("ntdll: Support more xstate features."). That is actually covered by existing ntdll/tests/exception but there are a couple of tests (related to gs override) which crash those tests. Just in case, attaching an ad-hoc patch which comments out those and let the rest run (and succeed here in wow64 mode with these patches). Properly skipping those probably require Wine check I am afraid. [test.patch](/uploads/9db61a514f4242add75e96cb9493e8c0/test.patch) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5473

2 2

[PATCH 0/1] MR5472: winecoreaudio: Correctly handle devices whose UID contains non-ASCII characters.
by Brendan Shanks (＠bshanks) 08 Apr '24

08 Apr '24

This should fix audio issues for users with certain USB audio devices (possibly including the Creative Pebble V3 and RØDECaster Pro II). The Core Audio UID can contain non-ASCII characters and is converted to UTF-8 by `unix_get_endpoint_ids`. But we were using `CFStringGetLength` to calculate the resulting size, which returns the length in UTF-16 code pairs. This resulted in any UIDs containing non-ASCII characters being truncated, `dev_id_from_device` later failing, and audio not working. Instead use `CFStringGetBytes` to calculate the resulting UTF-8 size, and to do the conversion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5472

2 1

[PATCH v3 0/10] MR768: Draft: vkd3d-shader/dxil: Tessellation part 2.
by Conor McCarthy (＠cmccarthy) 08 Apr '24

08 Apr '24

Goes atop !767. The last five commits belong here. -- v3: vkd3d-shader/dxil: Implement DX intrinsic OutputControlPointID. vkd3d-shader/dxil: Implement DX intrinsic DomainLocation. vkd3d-shader/dxil: Implement DX intrinsic StorePatchConstant. vkd3d-shader/dxil: Implement DX intrinsics LoadOutputControlPoint and LoadPatchConstant. vkd3d-shader/dxil: Support patch constant functions and signatures. vkd3d-shader/ir: Validate tessellation declarations. vkd3d-shader/dxil: Implement DX intrinsic PrimitiveID. vkd3d-shader/dxil: Load hull shader properties. vkd3d-shader/dxil: Load domain shader properties. tests/hlsl: Add a tessellation test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/768

3 13

[PATCH v5 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) 08 Apr '24

08 Apr '24

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v5: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 1

[PATCH v5 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.
by Nikolay Sivov (＠nsivov) 08 Apr '24

08 Apr '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: vkd3d-shader/hlsl: Add refract() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

2 2

[PATCH 0/1] MR770: tests/test-driver: Avoid "head" with negative line count.
by Henri Verbeet (＠hverbeet) 08 Apr '24

08 Apr '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/770

3 3

[PATCH v5 0/1] MR762: ci: Delimit building each commit with a collapsible section.
by Giovanni Mascellani (＠giomasce) 08 Apr '24

08 Apr '24

-- v5: ci: Delimit building each commit with a collapsible section. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/762

3 2

[PATCH v4 0/1] MR762: Draft: ci: Delimit building each commit with a collapsible section.
by Giovanni Mascellani (＠giomasce) 08 Apr '24

08 Apr '24

-- v4: ci: Delimit building each commit with a collapsible section. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/762

3 3

Re: [PATCH v11 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Henri Verbeet (＠hverbeet) 08 Apr '24

08 Apr '24

> > Which complications would those be? > > ResolveSubresource(), which I think we would also need in D3D12. It can be done but do we need it? Well, get_resource_readback_with_command_list_and_states() already handles multi-sampled readback for d3d12, so that part should be fine. It doesn't seem especially complicated to add to the d3d11 runner either? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734#note_67260

1 0

Re: [PATCH v11 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) 08 Apr '24

08 Apr '24

> Which complications would those be? ResolveSubresource(), which I think we would also need in D3D12. It can be done but do we need it? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734#note_67255

1 0

2025

2024

2023

2022

wine-gitlab April 2024