May 2024 - wine-gitlab

[PATCH v4 0/5] MR5385: winebus: ignore udev events of devices which do not have devnodes
by Tuomas Räsänen (＠tuomasjjrasanen) 28 May '24

28 May '24

Udev monitor monitors the whole input subsystem, but not all devices in the input subsystem have devnodes associated to them. This MR makes the event processing ignore such devices. All device handling assumes devices have devnodes, so here we just simply ignore all devices which do not have one. They are irrelevant. Previously, udev bus thread aborted when an event for a device without a devnode was processed: ``` 10111.330:0068:0084:trace:hid:process_monitor_event Received action "remove" for udev device (null) 10111.330:0068:0084:warn:hid:bus_main_thread L"UDEV" bus wait returned status 0xc0000005 ``` Just plugging in and out a normal mouse was enough cause this. This was because root input devices (which do not have devnodes) were handled too and `find_device_from_devnode()` choked on NULL argument. -- v4: winebus: change debugging class of an error case from WARN to ERR. winebus: change debugging class of an error case from FIXME to ERR winebus: group local variable declarations https://gitlab.winehq.org/wine/wine/-/merge_requests/5385

4 8

[PATCH 0/3] MR5328: wined3d: Fixes for ARB_bindless_texture support.
by Zebediah Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5328

4 5

[PATCH v8 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit.
by Anton Baskanov (＠baskanov) 28 May '24

28 May '24

-- v8: explorer: Restore display settings on process exit. winex11.drv: Process RRNotify events in xrandr14_get_id. user32/tests: Test that display settings are restored on process exit. https://gitlab.winehq.org/wine/wine/-/merge_requests/5060

4 10

[PATCH 0/1] MR5404: windows.perception.stub: Add stub IHolographicSpaceInterop interface.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5404

2 2

[PATCH v4 0/5] MR5306: win32u: Move D3DKMT vulkan implementation out of winex11.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

With some intermediate refactoring to make the code simpler. I believe the failures that happened previously were coming from how NtGdiDdDDIOpenAdapterFromLuid initialized desc->hAdapter in win32u while winex11 was then relying on it. I missed this detail before and it should be working fine now that the vulkan path is only used to retrieve the physical device. -- v4: win32u: Move D3DKMT vulkan implementation out of winex11. winex11: Introduce a new find_adapter_from_handle helper. winex11: Introduce a new get_vulkan_physical_device helper. winex11: Initialize D3DKMT vulkan instance only once. win32u: Open adapters in NtGdiDdDDIEnumAdapters2 outside of the display devices lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/5306

3 7

[PATCH 0/6] MR5724: widl: Various fixes.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724

2 6

[PATCH 0/3] MR5728: ntdll/tests: Rewrite the RtlQueryRegistryValues tests and succeed on direct query of nonexistent value.
by Alex Henrie (＠alexhenrie) 28 May '24

28 May '24

The original tests were very aspirational and didn't actually test much. https://bugs.winehq.org/show_bug.cgi?id=49703 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5728

2 3

Re: [PATCH 0/5] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

Tests failed. Apparently the AVI decoder is expected to enumerate formats that it doesn't actually support? ?_? and also ಠ_ಠ. Well, that's not the first insane part of Windows I've seen. Apparently something calls pin_query_accept anyways, so that patch is unnecessary. Also fixed 16bit BI_RGB in the iccvid patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5744#note_71576

1 0

Re: [PATCH v2 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

> > If you wish to have me removed as maintainer of winegstreamer, please propose that directly, rather than abusing GitLab to get your patches committed. > > This is not an automated process and I don't think I'm abusing any mechanism here. Well... unless I'm mistaken, it kind of is. The whole point of using Gitlab's reviewers feature is to have the software track things so that Alexandre doesn't have to. If he has to look at every patch to check if the right people have reviewed it then that point is defeated. If he's just looking for patches with no pending review [in areas that are known to have a maintainer] then removing a reviewer will make a patch effectively ready to commit. I can only assume this is why my patches to wined3d have been committed without Jan's approval when the bot flakes out and doesn't assign Jan as a reviewer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667#note_71571

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

On Tue May 28 07:03:51 2024 +0000, Rémi Bernon wrote: > Can this really happen? If that's the case then sure. Yes. I don't imagine anyone does it but it's how midl behaves. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71568

1 0

2025

2024

2023

2022

wine-gitlab May 2024