May 2024 - wine-gitlab

[PATCH 0/4] MR5639: comctl32/syslink: Don't delete font when destroying the control.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

The font set by WM_SETFONT is not owned by syslink so it shouldn't be deleted when handling WM_DESTROY for the control. Fix Toad for Oracle text gets reset to the system font after installing Team Coding. The application creates a font and set it to a syslink. Then after the syslink destroys itself, the font becomes invalid so other controls using the font end up falling back to the system font. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5639

4 6

Re: [PATCH v2 0/1] MR5706: comctl32/rebar: Hide chevron if the full width of rebar is displayed
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

Please give two screenshots demonstrating the changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5706#note_71557

1 0

Re: [PATCH v3 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Tue May 28 10:12:25 2024 +0000, Rémi Bernon wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/5738/diffs?diff_id=115405&start_sha=837a51a59c0de7dd45a2c7da92545ca8d18da2e2#85770a8b187bd82db4dbb9a2b8a5f34616049d0f_4787_4787) Dropped that change for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71550

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

On Tue May 28 10:20:03 2024 +0000, Alexandre Julliard wrote: > I don't think we can do that until the drivers support window scaling. Hmm, right thanks. That was mostly meant to fix the tests, but I see now that it breaks things. Still not clear to me why or how. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71547

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

Alexandre Julliard (@julliard) commented about dlls/win32u/sysparams.c: > > /* FIXME: what do the DpiScalingVer flags mean? */ > get_dword_entry( (union sysparam_all_entry *)&entry_DPISCALINGVER, 0, &dpi_scaling, 0 ); > - if (!dpi_scaling) NtUserSetProcessDpiAwarenessContext( NTUSER_DPI_PER_MONITOR_AWARE, 0 ); I don't think we can do that until the drivers support window scaling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71546

1 0

Re: [PATCH v2 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

> If you wish to have me removed as maintainer of winegstreamer, please propose that directly, rather than abusing GitLab to get your patches committed. This is not an automated process and I don't think I'm abusing any mechanism here. > I'm sorry for not reviewing I find it very difficult to want to review promptly when my review is invariably met with argument, insistence that there is only one correct way to do things, and inability or unwillingness to view things from my perspective. Despite this, I am sorry, and I will try to renew my efforts to review better. I could say the very same thing the other way, I don't see how that would help us though. I've been working on this for almost two years straight now, and yet, I still have to nag people to get ~5 patches reviewed in a week and still have to argue almost every time that my approach is as good as another. So yes, the more I'm doing it, the less I'm interested in rewriting things over. Note that this has now also been tested in length, and every large change requested is also waste of all the time that's been spend there too. Yes, of course, incorrectness needs to be addressed, but internal implementation details shouldn't matter as much as external behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667#note_71545

1 0

Re: [PATCH v2 0/4] MR5738: win32u: More DPI awareness context fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

v2: Fix some wineandroid build failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5738#note_71544

1 0

[PATCH 0/2] MR5737: Draft: kernelbase: Use ERROR_DIRECTORY for FindFirstFileExW on invalid name.
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

When `FindFirstFileA` is called with `<path>/<file>/*` (where file is expected to be a directory), Windows uses the `ERROR_DIRECTORY` error. This patch changes Wine's implementation to match Windows. This fixes a crash in Unity of Command II. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5737

3 4

Re: [PATCH v4 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Huw Davies (＠huw) 28 May '24

28 May '24

Huw Davies (@huw) commented about dlls/riched20/para.c: > COPY_FIELD(PFM_ALIGNMENT, wAlignment); > if (dwMask & PFM_TABSTOPS) > { > - para->fmt.cTabCount = pFmt->cTabCount; > - memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, pFmt->cTabCount*sizeof(LONG)); > + para->fmt.cTabCount = max(0, min(pFmt->cTabCount, MAX_TAB_STOPS)); /* Clamp between 0 and MAX_TAB_STOPS */ > + memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, para->fmt.cTabCount*sizeof(LONG)); ```suggestion:-1+0 /* Clamp between 0 and MAX_TAB_STOPS */ para->fmt.cTabCount = max(0, min(pFmt->cTabCount, MAX_TAB_STOPS)); memcpy(para->fmt.rgxTabs, pFmt->rgxTabs, para->fmt.cTabCount * sizeof(LONG)); ``` Otherwise, looks fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71529

1 0

[PATCH 0/2] MR5740: Inlcude updates
by Alistair Leslie-Hughes (＠alesliehughes) 28 May '24

28 May '24

Two patches to add two new interfaces and one to fix an existing one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5740

2 2

2025

2024

2023

2022

wine-gitlab May 2024