May 2024 - wine-gitlab

Re: [PATCH v2 0/1] MR5695: odbc32: Allow null handle for SQLSetEnvAttr. - approved
by Alexandre Julliard (＠julliard) 28 May '24

28 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5695

1 0

[PATCH v2 0/1] MR5683: ntdll: Fill object pointer in NtQueryInformation( SystemHandleInformation / SystemExtendedHandleInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v2: ntdll: Fill object pointer in NtQueryInformation( SystemHandleInformation / SystemExtendedHandleInformation ). https://gitlab.winehq.org/wine/wine/-/merge_requests/5683

2 3

[PATCH 0/4] MR5641: Cmd engine rewrite (part IV)
by eric pouech (＠epo) 28 May '24

28 May '24

This is the fourth part in cmd.exe's engine rewrite. It concerns: - start of decoupling parsing from execution by introducing ad hoc structure to hold parsing result to be passed for execution (done here for redirection, and if conditions), - refactor execution code with putting into helpers: + change of input/output streams + save / restore of input/output streams before / after execution Note: - the handling of fd > 2 is clearly wrong, but it just mimics the current implementation. More work will be required afterwards (likely using directly CRT low level I/O), - I kept a few specific debug channels in place. They will be removed (or simplified at some point), but they could be useful to debug remaining issues. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5641

4 8

[PATCH v3 0/6] MR5616: win32u: Enumerate and expose vulkan-only GPUs.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

This should achieve the same thing as https://github.com/ValveSoftware/wine/commit/e8801e96fedf67b88e6f3f5d9f9e2d… -- v3: win32u: Enumerate offscreen vulkan devices as GPU devices. win32u: Query GPU memory from vulkan physical device. win32u: Match driver GPUs with vulkan GPUS from their ids, or index. win32u: Keep a list of vulkan GPUS in the device manager context. win32u: Load the graphics driver vulkan functions lazily. win32u: Fix default_update_display_devices return type to NTSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5616

4 18

[PATCH 0/1] MR5694: msvcrt: Fix _kbhit ignoring the last event.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56697 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5694

3 2

[PATCH 0/1] MR5683: ntdll: Fill object pointer in NtQueryInformation( SystemHandleInformation / SystemExtendedHandleInformation ).
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5683

3 5

[PATCH v6 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v6: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

2 2

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Tue May 21 09:53:24 2024 +0000, eric pouech wrote: > using strtol would be better and save you the str_is_number helper I can switch to strtol, but how does it save the `str_is_number` helper? It returns 0, which is a valid (if useless) timeout value for the native program. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71016

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Tue May 21 12:09:30 2024 +0000, eric pouech wrote: > I'd rather see this outside the do/while loop (and moreover, the second > count down shall be printed after this message) Yes, but it only overrides the "Waiting for %s seconds" part, which mostly matches Windows' behavior (from the cursor position). The only difference is that Windows will end at "Waiting for N". While it's possible to replicate this, I believe it may cause issues with translations. I can move it outside the do/while loop though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71014

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 28 May '24

28 May '24

On Tue May 21 10:23:40 2024 +0000, eric pouech wrote: > why do you need float operations here? (int)(ticks_remaining / 1000) > should do It needs to be rounded because otherwise it will start with printing "Waiting for N-1 seconds" due to one or more ticks having elapsed (at least on my machine). But yes, I could do an int roundup instead (`(ticks_remaining + 500) / 1000`). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71013

1 0

2025

2024

2023

2022

wine-gitlab May 2024