Search names in fonts in the order of Microsoft, Mac and finally Unicode platform. This is also the
order win32u uses to load font names.
Fix Granado Espada Japan (1219160) launcher crashes at start in the Japanese locale. The game ships
a font with a broken name record of Mac platform and encoding ID 0 (Roman) but the name string is in
code page 10001 (Japanese). This broken name record is placed before the name records for the
Microsoft platform so it gets selected first. Then the name string in the name record doesn't get
converted correctly to Unicode because of the wrong code page. Thus the EnumFontFamiliesExW()
in GdipPrivateAddMemoryFont() fails to find the font and causes game crash.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5421
On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote:
> Also, in the commit message subject. Not just the MR subject.
OK, I think I got it ! I'll keep these in mind for next time.
[image](/uploads/233f99f4dd99c94026b9161be7194eb4/image.png)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66885
On Thu Apr 4 08:24:18 2024 +0000, Sam Joan Roque-Worcel wrote:
> Woops! That's what you get for coding late at night. I've hopefully
> addressed it now
We usually add a dot at the end of the message subject. Please do that as well.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66876