July 2024 - wine-gitlab

[PATCH v10 0/9] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 29 Oct '24

29 Oct '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v10: userenv: Fix GetProfilesDirectoryA return value kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. userenv: Add another test for GetProfilesDirectoryA https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 12

[PATCH 0/5] MR4614: msvcm80: Add missing function implementations
by Vijay Kiran Kamuju (＠infyquest) 26 Oct '24

26 Oct '24

This series adds _Cin, _Cout, _Cerr, _Clog, _Wcin, _Wcout, _Wcerr, _Wclog functions. Rest of the functions will be added later. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47304 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=32091 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4614

4 10

[PATCH v4 0/2] MR6158: Replaced on simpler functions with char, wchar_t parameter if possible
by Herman Semenov (＠GermanAizek) 21 Oct '24

21 Oct '24

Example my assembly with gcc -02 flag Before: ![screen_before](/uploads/f2bf5f4c793c159c31ac42b635c46d5a/screen_before.jpg) After: ![screen_after](/uploads/051315ad1e3c064046446782d36e1a29/screen_after.jpg) -- v4: d3dcompiler: replaced to char, wchar_t parameter if possible wcmdmain: replaced to char, wchar_t parameter if possible https://gitlab.winehq.org/wine/wine/-/merge_requests/6158

4 10

[PATCH v2 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe
by Herman Semenov (＠GermanAizek) 21 Oct '24

21 Oct '24

I think this PR changes will protect against situation if out-of-bounds access array. -- v2: comctl32: fixed first we check index then array access by index is safe https://gitlab.winehq.org/wine/wine/-/merge_requests/6169

6 8

[PATCH 0/1] MR5276: musl: Fix limiting the float precision in intermediates.
by Martin Storsjö (＠mstorsjo) 15 Oct '24

15 Oct '24

musl itself expects to be configured to compile with either -ffloat-store or -fexcess-precision=standard - but when imported into Wine, those flags aren't used. This seems to be essential for getting reasonable precision from some math functions such as exp2() - without the expected precision truncation, the output value of exp2() can be off by as much as 0.2% in some cases. As Wine doesn't build the musl sources with those flags, use volatile to force storing/reloading floats in order to limit their intermediate precision, as musl expects. Only do this on i386 where this is known be required. This fixes https://bugs.winehq.org/show_bug.cgi?id=56372. Apparently this issue only appears when compiled with GCC; with Clang, this already works as expected. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5276

4 6

[PATCH v6 0/5] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 03 Oct '24

03 Oct '24

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v6: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. server: Add stub lookup_name implementation for named_pipe_device_file_ops. server: Pass the object subpath to open_file instead of rejecting it. server: Inline open_named_object() call in open_file_object handler. ntdll/tests: Test opening a named pipe with \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

4 11

[PATCH 0/2] MR3421: win32u: Fix clip_fullscreen_window for Deus Ex
by Zsolt Vadász (＠zsoltiv) 03 Oct '24

03 Oct '24

These changes fix the camera rotation for Deus Ex. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3421

3 7

[PATCH 0/1] MR5787: winevulkan: Use an internal NtUser call to retrieve a GPU LUID.
by Rémi Bernon (＠rbernon) 13 Sep '24

13 Sep '24

Avoid taking the display_device_init mutex outside of win32u. Similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/5786, although this one doesn't cause any problems as far as I know. Still makes things simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5787

3 6

[PATCH 0/10] MR4201: widl: Cleanup and simplify expressions.
by Rémi Bernon (＠rbernon) 13 Sep '24

13 Sep '24

Some cleanup for expressions, sanitizing the structure a bit especially for abstract operations with multiple args. I also found out about named bison variables, implicit (as `$token` referring to `token`), or explicit (as `$name` referring to `token[name]`). I think it would make the rules much more readable so I started using them here. My plan is to add them progressively to the rules, unless there's some good reason not to (like idk how portable they are, if that's something we should be worried about). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4201

3 21

[PATCH v4 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon (＠rbernon) 10 Sep '24

10 Sep '24

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- v4: win32u: Use GDI blit to implement partial or other process presentation. winex11: Return an offscreen HDC from vulkan_surface_detach. win32u: Pass a HDC parameter to vulkan_surface_detach. winex11: Create a window surface even when there is client window. winex11: Also attach child client windows to their toplevel window. win32u: Make sure vulkan windows have a pixel format selected. win32u: Detach vulkan surfaces that aren't fully visible. win32u: Detach offscreen, child or vulkan surfaces for another process. win32u: Move vulkan surfaces to their new parent when reparenting. win32u: Introduce a new vulkan offscreen surfaces list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

7 20

2025

2024

2023

2022

wine-gitlab July 2024