July 2024 - wine-gitlab

[PATCH 0/1] MR6140: ntdll: Exclude biggest envars to fit 32767 chars limit in get_initial_environment.
by Martino Fontana (＠tinozzo123) 27 Jul '24

27 Jul '24

Windows has a limit of 32767 characters in the environment block. https://superuser.com/questions/1070272/why-does-windows-have-a-limit-on-en… Wine doesn't attempt to respect that at all. Do some programs actually depend on this? Unfortunately yes. With this patch, during initialization, if the block size would exceed (or be close to) the limit, the biggest environment variables will be excluded. This is useful when a user has very long environment variables in their system for reasons unrelated to Wine. Do note that there's still nothing done to make sure that the limit isn't exceeded after initialization. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56941 Signed-off-by: Martino Fontana <tinozzo123(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6140

7 10

[PATCH 0/3] MR6165: widl: Propagate attrs to inner pointer types.
by Elizabeth Figura (＠zfigura) 27 Jul '24

27 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6165

3 4

[PATCH v7 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v7: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. kernel32: Rework ExpandEnvironmentStringsW error handling. ntdll: Rework RtlExpandEnvironmentStrings/_U to account for corner cases. kernel32: Add ExpandEnvironmentStringsA tests for japanese. kernel32: Add more tests for ExpandEnvironmentStringsA. kernel32: Add tests for ExpandEnvironmentStringsW. ntdll: Add more tests for RtlExpandEnvironmentStrings/_U. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 8

[PATCH v6 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v6: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 9

Re: [PATCH v3 0/1] MR5957: win32u: fix random crash without libfreetype
by Fabian Maurer (＠DarkShadow44) 27 Jul '24

27 Jul '24

Fabian Maurer (@DarkShadow44) commented about dlls/win32u/sysparams.c: > 'r','s','t','u','v','w','x','y','z','A','B','C','D','E','F','G','H', > 'I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'}; > > - if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) return 0; > + if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) goto fail; > > if (!NtGdiGetTextExtentExW( hdc, abcdW, ARRAYSIZE(abcdW), 0, NULL, NULL, &sz, 0 )) > - return 0; > + goto fail; > > if (height) *height = sz.cy; > return (sz.cx / 26 + 1) / 2; > +fail: > + if (height) *height = 1; > + return 0; Just curious, but why `1`? Also, wouldn't it be easier to have `if (height) *height = 1;` at the beginning of the function? Then you could keep the rest the same. And maybe that function could zero the `metrics` as well? Not sure where it would be required, I find a setup without freetype strange to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5957#note_77190

1 0

[PATCH v3 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 27 Jul '24

27 Jul '24

-- v3: shell32: Fix FO_MOVE when destination has conflicting directory. shell32/tests: Add tests for moving dir(s) to destination(s) with conflicting dir. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

3 3

[PATCH v4 0/1] MR5586: configure: Test PE compilers after setting their target argument.
by Billy Laws (＠bylaws) 27 Jul '24

27 Jul '24

clang will default to the host if no target is specified, which causes compile test failures if arch-specific CFLAGS are used for a non-host arch. -- v4: configure: Test PE compilers after setting their target argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/5586

3 4

[PATCH 0/1] MR6161: gdiplus: fixed order adding offset and result ternary operator
by Herman Semenov (＠GermanAizek) 27 Jul '24

27 Jul '24

Reference: https://en.cppreference.com/w/c/language/operator_precedence -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6161

3 2

[PATCH 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) 26 Jul '24

26 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

2 2

Re: [PATCH v8 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS. - approved
by Huw Davies (＠huw) 26 Jul '24

26 Jul '24

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

1 0

2025

2024

2023

2022

wine-gitlab July 2024