The handles returned by libproc (namely struct socket_info's soi_pcb)
use all 64 bits, but the ones from the pcblist sysctl are truncated
to 32. That makes find_owning_pid fail. The pcblist64 sysctl was
added in macOS 10.6 and returns handles that match those from
libproc.
--
There does not seem to be a MIB constant for the pcblist64 sysctls, so I'm caching the result of sysctlnametomib.
--
v6: nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6021
On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote:
> test-linux-32 always failed, can you see the reason for the failure?
Just open [it](https://gitlab.winehq.org/fanwenjie/wine/-/jobs/89772) and scroll around until you find a colored block, then look for red lines in that block.
If it has nothing to do with your changes (for example because it's about sockets or batch files), then it's broken on master too, and is someone else's problem. Just ignore it, it won't block merging. Don't rerun it, it'll just fail again.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77150
On Fri Jul 26 10:09:51 2024 +0000, Rémi Bernon wrote:
> Fwiw, on Windows, all desktops are of the same size, which only depends
> on the set of monitors which are plugged in.
> IMO we should implement support for multiple virtual monitors, rather
> than going back to the old virtual desktop logic.
desktop is not equals to monitor, currently wine supports multiply desktops (mutiply host window) on a virtual monitor. only need one virtual monitor because it is only a virtual device.
In virtual desktop mode
desktop = host platform window
virtual monitor=dummy host monitor device
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77129
Fwiw, on Windows, all desktops are of the same size, which only depends on the set of monitors which are plugged in.
IMO we should implement support for multiple virtual monitors, rather than going back to the old virtual desktop logic.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77123
You can add Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 at the end of your commit message body.
Also, the wrong commit is b86cc9e6, not fecfb442
```
(b86cc9e6589...)|BISECTING:wine/win32-build$ git bisect bad
b86cc9e658959cee47e6e587fec4f7c26350ed76 is the first bad commit
commit b86cc9e658959cee47e6e587fec4f7c26350ed76
Author: Rémi Bernon <rbernon(a)codeweavers.com>
Date: Tue Feb 13 15:05:37 2024 +0100
winex11: Let win32u decide when to force update the display cache.
dlls/winex11.drv/window.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
```
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77120