On Wed Aug 21 21:46:56 2024 +0000, Vibhav Pant wrote:
> Hm, I wasn't able to split the changes here to commits cleanly here :/.
> However, some of the functionality being separated into `new_event`
> should make the code easier to read, perhaps?
The revert + squash trick worked great. Thanks! Let me know if I can organize the commits any better.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79639
IoGetDevicePropertyData is used to implement the `IOCTL_BTH_GET_DEVICE_INFO` Bluetooth IOCTL to fetch cached information for remote devices, without having to access the device extension pointer (which is arguably racy and more fragile).
--
v7: ntoskrnl/tests: Add test for getting and setting device properties.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6338
IoGetDevicePropertyData is used to implement the `IOCTL_BTH_GET_DEVICE_INFO` Bluetooth IOCTL to fetch cached information for remote devices, without having to access the device extension pointer (which is arguably racy and more fragile).
--
v6: ntoskrnl/tests: Add test for getting and setting device properties.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6338
IoGetDevicePropertyData is used to implement the `IOCTL_BTH_GET_DEVICE_INFO` Bluetooth IOCTL to fetch cached information for remote devices, without having to access the device extension pointer (which is arguably racy and more fragile).
--
v5: ntoskrnl/tests: Add test for getting and setting device properties.
ntoskrnl: Implement IoGetDevicePropertyData().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6338
Tests can fail (seen on slow VMs) because `GetExitCodeProcess` is called before the child process is marked as terminated. `STILL_ACTIVE` is returned instead of the expected `1`.
dlls/kernel32/tests/loader.c#L3984 does a similar thing.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6339
IoGetDevicePropertyData is used to implement the `IOCTL_BTH_GET_DEVICE_INFO` Bluetooth IOCTL to fetch cached information for remote devices, without having to access the device extension pointer (which is arguably racy and more fragile).
--
v4: ntoskrnl: Implement IoGetDevicePropertyData().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6338