August 2024 - wine-gitlab

Re: [PATCH v29 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Elizabeth Figura (＠zfigura) 23 Aug '24

23 Aug '24

On Thu Aug 22 19:02:16 2024 +0000, Vibhav Pant wrote: > It might be too wordy, but what about `with_notify_registration`? I was > initially thinking `with_hdevnotify`, but that's not very communicative either. I think with_hdevnotify is better actually; it requires you to know what a HDEVNOTIFY is but is otherwise clear and unambiguous. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79796

1 0

[PATCH v9 0/2] MR6338: ntoskrnl: Implement IoGetDevicePropertyData().
by Vibhav Pant (＠vibhavp) 23 Aug '24

23 Aug '24

IoGetDevicePropertyData is used to implement the `IOCTL_BTH_GET_DEVICE_INFO` Bluetooth IOCTL to fetch cached information for remote devices, without having to access the device extension pointer (which is arguably racy and more fragile). -- v9: ntoskrnl/tests: Add test for getting and setting device properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/6338

4 5

[PATCH 0/1] MR6347: advpack: DelNode support the ADN_DEL_IF_EMPTY flag
by Anders Kjersem (＠anders) 23 Aug '24

23 Aug '24

Fixes a bug where `rundll32.exe advpack.dll,DelNodeRunDLL32 "c:\test",1` is only supposed to delete "test" if the directory is empty. Also causes the [DelDirs Inf section](https://www.mdgx.com/INF_web/deldirs.htm) to work correctly. Notes: - I changed the code so it ignores the result of `SetFileAttributesW` because the user might not have FILE_WRITE_ATTRIBUTES even if they have DELETE rights. This seems to match Windows (XP NTFS). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6347

3 2

[PATCH 0/1] MR6345: kernel32: PowerCreateRequest return a valid handle
by Alistair Leslie-Hughes (＠alesliehughes) 23 Aug '24

23 Aug '24

When the application is finished with this handle, CloseHandle should be used. This was causing steam to crash when viewing content. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6345

5 5

Re: [PATCH v4 0/2] MR6294: mlang: Fix bug when multibyte string truncation in ConvertINetMultiByteToUnicode
by Alexandre Julliard (＠julliard) 23 Aug '24

23 Aug '24

Alexandre Julliard (@julliard) commented about dlls/mlang/mlang.c: > default: > if (*pcSrcSize == -1) > *pcSrcSize = lstrlenA(pSrcStr); > - > + while (MultiByteToWideChar(dwEncoding, MB_ERR_INVALID_CHARS, pSrcStr, *pcSrcSize, 0, 0) == 0) > + { > + (*pcSrcSize)--; > + } This will truncate at the first invalid char, it would need a test to show that this is the correct behavior. Also it won't do the right thing for a zero-length string. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6294#note_79775

1 0

[PATCH 0/2] MR6346: winex11.drv: Properly check if the desktop window is fullscreen on multi-monitor systems.
by Zhiyi Zhang (＠zhiyi) 23 Aug '24

23 Aug '24

If there are two monitors and the primary monitor is on the right side and the virtual desktop resolution happens to be the same as the primary monitor, then the X11 desktop window will not have window frames and show as a fullscreen window before this patch. is_desktop_fullscreen() should check which monitor that it is on to decide whether to use fullscreen mode instead of always checking against the primary monitor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6346

3 4

[PATCH v3 0/3] MR6317: comctl32: handle large tooltip icons
by Cherser-s (＠Cherser-s) 23 Aug '24

23 Aug '24

Added 32x32 icons for TTI_INFO_LARGE, TTI_WARNING_LARGE and TTI_ERROR_LARGE. User-defined icons passed through TTM_SETTITLE message are still drawn as 16x16 icons. -- v3: comctl32: changed tooltip icon indices to match the native library https://gitlab.winehq.org/wine/wine/-/merge_requests/6317

4 10

[PATCH 0/2] MR6343: comctl32/imagelist: Remove version check in ImageList_Read().
by Jacob Czekalla (＠JacobCzekalla) 23 Aug '24

23 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=18382 If an imagelist is created and stored to a file on windows using WriteEx(ImageList_WriteEx is not implemented in WINE), and it is read using ImageList_Read(), it should still read just fine on Windows. On WINE we see the version mismatch as it was made using V6 Comctl32 and WriteEx and return -1 instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6343

4 7

[PATCH v2 0/3] MR6333: odbccp32 valid dsn
by Alistair Leslie-Hughes (＠alesliehughes) 23 Aug '24

23 Aug '24

-- v2: odbccp32: SQLWrite/RemoveDSNFromIniW correctly handle config_mode odbccp32: SQLRemoveDSNFromIniW check for valid DSN before delete odbccp32: SQLValidDSNW return false on empty string. https://gitlab.winehq.org/wine/wine/-/merge_requests/6333

3 4

[PATCH v10 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect.
by Jacob Czekalla (＠JacobCzekalla) 23 Aug '24

23 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- v10: comctl32/edit: Fix incorrect size for format rect when it is smaller than text. https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

3 12

2025

2024

2023

2022

wine-gitlab August 2024