August 2024 - wine-gitlab

Re: [PATCH v20 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Elizabeth Figura (＠zfigura) 21 Aug '24

21 Aug '24

On Wed Aug 21 14:12:47 2024 +0000, Vibhav Pant wrote: > Yup, moved it. However, I haven't inlined it, as I wanted to also add a > log entry whenever `device_notify_proc` matches an incoming event > against a registered notification filter, just before the `struct > device_broadcast` object is dispatched to the corresponding callback. > Would that be too noisy? If yes, I'll go ahead and inline it. I can only speak for myself, but I don't imagine I would find a TRACE like that too noisy. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79506

1 0

Re: [PATCH v20 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Elizabeth Figura (＠zfigura) 21 Aug '24

21 Aug '24

On Wed Aug 21 13:01:35 2024 +0000, Vibhav Pant wrote: > > Note that if you're using DWORD (and you could just as easily use > "unsigned int" instead) you probably want "%lu" rather than casting to int. > Yeah, I was a little confused if there's a format specification > convention used by Wine for unsigned type variables used for storing > size. Except for `%#Ix` used to `SIZE_T`, I could only see `ULONG`s > being cast to int and then being printed with `%d`, so that's what I > went with to be safe. But yeah, `%lu` makes more sense. I think %u/%d vs %#x is mostly a matter of "best judgement", but in general you should use the right signed variant, and in PE code you shouldn't need to cast to get the right length specifier (though it may require a bit of extra knowledge: %d for int, %ld for long [which is always 32-bit on Windows], %Id for anything pointer-size, %I64d for 64-bit types [note that 'long long' is always 64-bit, but can't be used.]) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79505

1 0

Re: [PATCH v20 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Elizabeth Figura (＠zfigura) 21 Aug '24

21 Aug '24

On Wed Aug 21 14:08:25 2024 +0000, Vibhav Pant wrote: > changed this line in [version 15 of the diff](/wine/wine/-/merge_requests/6315/diffs?diff_id=127699&start_sha=200a214bfb66f40ec311b78086abe9c3b95ba36a#c24d5a128c8e2e7df00647f30fabed6de6e42a52_2_0) Hmm indeed. I'm not sure there's any reason we shouldn't do something like the attached patch in general, but that's for another merge request. [scratch.diff](/uploads/36b496a0f6da14780df7bf853560835a/scratch.diff) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79504

1 0

[PATCH v10 0/2] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) 21 Aug '24

21 Aug '24

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v10: shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

4 5

[PATCH 0/2] MR6322: jscript: eval and JSON fixes
by Gabriel Ivăncescu (＠insn) 21 Aug '24

21 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6322

3 8

[PATCH v3 0/1] MR6316: netutils: Forward some exports to netapi32.
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Aug '24

21 Aug '24

Fixes Lineage 2 -- v3: netapi32: Move some implementations to netutils. https://gitlab.winehq.org/wine/wine/-/merge_requests/6316

4 3

Re: [PATCH v4 0/1] MR2378: kernelbase: Trick V8's CHECK(old_protection == PAGE_READWRITE).
by Aida Jonikienė (＠DodoGTA) 21 Aug '24

21 Aug '24

> I think it's being worked on by someone else anyway Is there a public branch for that work (or is that work too WIP to publish it)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2378#note_79485

1 0

[PATCH v6 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect.
by Jacob Czekalla (＠JacobCzekalla) 21 Aug '24

21 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- v6: comctl32/edit: Fix incorrect size for format rect when it is smaller than text. https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

3 5

Re: [PATCH v4 0/1] MR2378: kernelbase: Trick V8's CHECK(old_protection == PAGE_READWRITE).
by Elizabeth Figura (＠zfigura) 21 Aug '24

21 Aug '24

> Reworking the ntdll-WRITECOPY wine-staging patchset would be a good start That's not really helpful advice by itself. The wine-staging patch set is fundamentally not workable as an approach. There is at this point a more or less specific idea of what needs to be done to properly implement WRITECOPY support, basically involving IOCTL_PAGEMAP_SCAN, and I think it's being worked on by someone else anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2378#note_79484

1 0

[PATCH v2 0/2] MR6317: comctl32: handle large tooltip icons
by Cherser-s (＠Cherser-s) 21 Aug '24

21 Aug '24

Added 32x32 icons for TTI_INFO_LARGE, TTI_WARNING_LARGE and TTI_ERROR_LARGE. User-defined icons passed through TTM_SETTITLE message are still drawn as 16x16 icons. -- v2: explorer.exe: fix handling ballon icon flags comctl32: handle large tooltip icons https://gitlab.winehq.org/wine/wine/-/merge_requests/6317

4 7

2025

2024

2023

2022

wine-gitlab August 2024